Ability to follow and unfollow a user

[folkemat]

Hi, this PR adds the ability to follow and unfollow a user.

• There is now a Follow / Unfollow button in the profile
• Since following is nothing more than subscribing to a subreddit called "u_username", followed users appear in the main menu under "Subscribed Subreddits"
• Followed users get a "Followed" chip in their profile

Closes #1156 and #700

What do you think? I look forward to your feedback

[folkemat]

I've noticed that if you follow a user using the "u_username" scheme, e.g. "u_spez", a subreddit "/user/spez" (which opens the profile) and one called "u_spez" (which actually shows the posts in "r/u_spez") are created: u_spez is removed when the main menu is refreshed, while /user/spez only appears after the refresh.

No idea why that is, but I don't know the code much either, maybe you have an explanation @QuantumBadger? Or is it a Reddit thing? reddit.com/r/u_spez also automatically redirects to reddit.com/user/spez.

So..

• To follow you have to use the u_username scheme, because /user/username doesn't work.
• To unfollow, you can use both schemas, but we have to test if we should use u_username or /user/username works, because who knows if u_spez was already upgraded to /user/spez or not.
• And to display the chip and the correct buttons we also have to check both for the same reason

I have now simply solved it by testing for both, but maybe it is better to somehow trigger an refresh after following?

[folkemat]

I just noticed: The whole thing now has to be adapted to the block/unblock behaviour; no toast messages, but greyed out (un)follow loading buttons. I'll do that soon

[t-e-s-tweb]

any follow-up to this feature?

[QuantumBadger]

Thanks @folkemat, and sorry for the delay in responding. I've added some fixes and rebased this on the latest master.

I've noticed that if you follow a user using the "u_username" scheme, e.g. "u_spez", a subreddit "/user/spez" (which opens the profile) and one called "u_spez" (which actually shows the posts in "r/u_spez") are created: u_spez is removed when the main menu is refreshed, while /user/spez only appears after the refresh.

The subreddit gets added to the local list in onSubscriptionAttempt() and onSubscriptionAttemptSuccess(), so to address this I assume we'd have to store the subreddit name as /user/abc in canonical form, and then rewrite it to u_abc at the point when we make the subscription API call in subscriptionAction().

I just noticed: The whole thing now has to be adapted to the block/unblock behaviour; no toast messages, but greyed out (un)follow loading buttons. I'll do that soon

That would be great, thanks!