feat: Add back a process semaphore#24
Merged
Merged
Conversation
Reverts the change that removed the process semaphore for async subprocesses as having too many processes in large test suites was causing resource exhaustion on Apple devices. Adds a dependency on num_cpus to figure out an appropriate number of permits rather than just guessing 8 as before. A similar change may be necessary for sync process management.
johnchildren
changed the title
qfreewilll
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the change that removed the process semaphore for async subprocesses as having too many processes in large test suites was causing resource exhaustion on Apple devices.
Adds a dependency on num_cpus to figure out an appropriate number of permits rather than just guessing 8 as before.
A similar change may be necessary for sync process management.