Remove bound on ibm_db. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 18 18
Lines 2053 2053
=======================================
Hits 1900 1900
Misses 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ivergara
reviewed
Mar 11, 2025
pixi.toml
Outdated
| @@ -54,8 +54,7 @@ test = "pytest tests/integration --backend=postgres" | |||
| coverage = "pytest tests/integration --cov=datajudge --cov-report=xml --cov-append --backend=postgres" | |||
|
|
|||
| [feature.db2.dependencies] | |||
| # Upper bounded due to https://github.com/ibmdb/python-ibmdb/issues/986 | |||
| ibm_db = "<=3.2.4" | |||
| ibm_db = "*" | |||
There was a problem hiding this comment.
Shouldn't it be better to scope the misbehaving version(s) out?
There was a problem hiding this comment.
You're right of course!
9022938
ivergara
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a bound on
ibm_dbin #260 due to issues with recent versions of the package.These issues have faded since conda-forge/ibm_db-feedstock#81.
Therefore this PR removes the upper bound on
ibm_dbagain.