Skip to content

emscripten 3.1.73 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ jobs:

emscripten:
strategy:
matrix:
include:
- emscripten_version: 3.1.27
fail-fast: false
runs-on: ubuntu-latest
steps:
Expand All @@ -174,25 +171,19 @@ jobs:
- name: install emscripten
shell: bash -l {0}
run: |
git clone https://github.com/emscripten-core/emsdk.git
cd emsdk
./emsdk install ${{ matrix.emscripten_version }}
source ./emsdk_env.sh

#- name: install playwright
# shell: bash -l {0}
# run: |
# playwright install

#- name: run emscripten tests
# shell: bash -l {0}
# run: |
# cd emsdk
# ./emsdk activate ${{ matrix.emscripten_version }}
# source ./emsdk_env.sh
# cd ..
# chmod +x ./test/emscripten/test_emscripten.sh
# ./test/emscripten/test_emscripten.sh
$MAMBA_EXE install -c conda-forge -c https://repo.prefix.dev/emscripten-forge-dev \
emscripten_emscripten-wasm32 --yes

- name: install playwright
shell: bash -l {0}
run: |
playwright install

- name: run emscripten tests
shell: bash -l {0}
run: |
chmod +x ./test/emscripten/test_emscripten.sh
./test/emscripten/test_emscripten.sh

docs:
strategy:
Expand Down
5 changes: 5 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ endif()
# Flags
################################################################
if(EMSCRIPTEN)
# extra flags to ensure runtime methods are exported
set(EMS"SHELL: -s EXTRA_EXPORTED_RUNTIME_METHODS=['FS','PATH','loadDynamicLibrary']")
target_compile_options(xplugin_host INTERFACE ${EMS})
target_link_options(xplugin_host INTERFACE ${EMS})

# compiler flags
set_target_properties(xplugin_host PROPERTIES COMPILE_FLAGS "-s MAIN_MODULE=1")
set_target_properties(xplugin_plugin PROPERTIES COMPILE_FLAGS "-s SIDE_MODULE=1")
Expand Down
2 changes: 1 addition & 1 deletion environment_emscripten.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ channels:
dependencies:
- cmake
- python
- microsoft::playwright
- microsoft::playwright <= 1.50
Loading