Skip to content

🌐 [translation-sync] FIX: lecture cleanup batch from the 2026-08 tracker audit - #93

Closed
mmcky wants to merge 14 commits into
mainfrom
translation-sync-2026-08-18T03-42-16-pr-595
Closed

🌐 [translation-sync] FIX: lecture cleanup batch from the 2026-08 tracker audit#93
mmcky wants to merge 14 commits into
mainfrom
translation-sync-2026-08-18T03-42-16-pr-595

Conversation

@mmcky

@mmcky mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#595 - FIX: lecture cleanup batch from the 2026-08 tracker audit

Files Updated

  • ✏️ lectures/about_py.md
  • ✏️ .translate/state/about_py.md.yml
  • ✏️ lectures/autodiff.md
  • ✏️ .translate/state/autodiff.md.yml
  • ✏️ lectures/numpy.md
  • ✏️ .translate/state/numpy.md.yml
  • ✏️ lectures/pandas.md
  • ✏️ .translate/state/pandas.md.yml
  • ✏️ lectures/pandas_panel.md
  • ✏️ .translate/state/pandas_panel.md.yml
  • ✏️ lectures/polars.md
  • ✏️ .translate/state/polars.md.yml
  • ✏️ lectures/python_by_example.md
  • ✏️ .translate/state/python_by_example.md.yml

Details

  • Source Language: en
  • Target Language: zh-cn
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

Copilot AI lite review requested due to automatic review settings August 18, 2026 03:42
@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Translation Quality Review

Verdict: WARN | Model: claude-sonnet-5 | Date: 2026-08-18
Routing: editor — verdict WARN (auto-merge requires PASS); 1 major finding(s); 2 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other); accuracy 8 below floor 9; terminology 8 below floor 9; formatting 6 below floor 8
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 8/10
Fluency 9/10
Terminology 8/10
Formatting 6/10
Overall 8/10

Summary: The translation of the modified sections (Series, Performance comparison, Exercises) is accurate, fluent, and terminologically consistent with the glossary and established style conventions. Formatting, spacing, and punctuation rules are correctly followed. The one notable issue is a URL substitution in the unchanged 'DataFrames' section that creates inconsistency with the retained original URL in 'Performance comparison', though this section was not marked as changed and is flagged only for awareness. Overall, this is a high-quality translation requiring minimal further revision within the scope of the changed sections. The 'Series' and 'Performance comparison' sections accurately preserve all technical meaning, including nuanced explanations of lazy vs eager evaluation and benchmarking methodology Consistent and correct use of established terminology (惰性求值, 谓词下推, 投影下推, 加权平均) matching glossary conventions Proper full-width Chinese punctuation used throughout changed sections, and correct spacing around inline MyST directives and code The Exercises section's note about join ordering and no-index/no-alignment theme is translated with clear, faithful phrasing that preserves the technical nuance of the original

Suggestions:

  • [major · formatting] lectures/polars.md — ## DataFrames, data source URL: The URL for the Penn World Tables CSV data was changed from the original GitHub raw URL (matching the English source in this section context, e.g. as used later in '### Performance comparison') to a different shortened URL 'https://github.com/QuantEcon/data-lectures/raw/main/lectures/test_pwt.csv'. While this section is technically outside the marked changed sections, the inconsistency is worth n… → Use the same URL as in the English source consistently: 'https://raw.githubusercontent.com/QuantEcon/lecture-python-programming/main/lectures/_static/lecture_specific/pandas/data/test_pwt.csv'
  • [minor · terminology] lectures/polars.md — ### Performance comparison, 'On a handful of rows the speed difference is immaterial': The translation '寥寥数行' is slightly more literary/formal than the neutral English phrase 'a handful of rows', but this is a stylistic nuance rather than an error; overall translation is accurate and natural.
  • [minor · fluency] lectures/polars.md — ## Series note on row index: Minor stylistic point: '更多详情请参阅' reads slightly formal but is acceptable and consistent with the rest of the document's register.

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 7.5/10

Summary: The target document's actual change does not correspond to the source's actual changes; it incorrectly modifies an unrelated URL rather than the rng/drop_nulls updates that were the real diff.

Issues:

  • The target's actual diff modifies the 'Reload the dataset' URL in the Lazy evaluation section (reverting to long raw.githubusercontent.com URL), which does not correspond to any change made in the source document.
  • The source's real changes (rng.standard_normal/default_rng modernization in Series/Performance sections, drop_nulls() fix in exercise solution) were already present in both target Before/After and were not the actual diff applied — meaning the sync applied the wrong change.
  • This creates an inconsistency: the 'small_pd'/'small_pl' block still uses the short GitHub URL while the 'df_full' reload block now uses the long URL, whereas in the source both use the same long URL consistently.

This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is an automated zh-cn translation sync from QuantEcon/lecture-python-programming (source PR #595), updating translated lecture content and the translation-state tracking metadata.

Changes:

  • Updated the test_pwt.csv dataset URL used in two Polars lecture code cells.
  • Refreshed .translate/state/*.yml metadata (source SHA, sync date, tool version) for multiple lectures.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lectures/polars.md Updates dataset URL used in Polars examples (two code cells).
.translate/state/about_py.md.yml Updates translation sync metadata (date/tool version).
.translate/state/autodiff.md.yml Updates translation sync metadata (date/tool version).
.translate/state/numpy.md.yml Updates translation sync metadata (date/tool version).
.translate/state/pandas.md.yml Updates translation sync metadata (source SHA).
.translate/state/pandas_panel.md.yml Updates translation sync metadata (date/tool version).
.translate/state/polars.md.yml Updates translation sync metadata (source SHA).
.translate/state/python_by_example.md.yml Updates translation sync metadata (date/tool version).
Suppressed comments (1)

lectures/polars.md:440

  • Same issue as above: this block uses the new raw.githubusercontent.com/QuantEcon/lecture-python-programming/.../test_pwt.csv URL, but the lecture still has an earlier test_pwt.csv URL pointing at the data-lectures repo. Please keep all test_pwt.csv references in this lecture consistent (or reuse a single shared constant).
url = ('https://raw.githubusercontent.com/QuantEcon/'
       'lecture-python-programming/main/lectures/_static/'
       'lecture_specific/pandas/data/test_pwt.csv')
small_pd = pd.read_csv(url)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lectures/polars.md
Comment on lines +360 to 363
url = ('https://raw.githubusercontent.com/QuantEcon/'
'lecture-python-programming/main/lectures/_static/'
'lecture_specific/pandas/data/test_pwt.csv')
df_full = pl.read_csv(url)
@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this regeneration was built from the source PR's merge-time snapshot, which predates the test_pwt repoint (lecture-python-programming#612) — its only lecture-content change is reverting two polars.md reads to the old own-repo URL, which will 404 when the migrated file is deleted. The batch itself already landed here as #92's predecessor #89, so nothing of value is lost.

@mmcky mmcky closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants