Update drawdown calculation to use High/Low instead of close only prices#9354
Open
JosueNina wants to merge 6 commits intoQuantConnect:masterfrom
Open
Update drawdown calculation to use High/Low instead of close only prices#9354JosueNina wants to merge 6 commits intoQuantConnect:masterfrom
JosueNina wants to merge 6 commits intoQuantConnect:masterfrom
Conversation
|
Did I build this |
|
I investigated the failing Benchmarks job and the instability is concentrated in EmptySingleSecuritySecondEquityBenchmark. I pushed a targeted optimization commit that avoids extra allocations/type checks in Statistics.CalculateDrawdownMetrics while preserving the OHLC drawdown logic from this PR. Commit: KeerthiCHS@e20ceda You can apply it on this PR branch with: |
Collaborator
Author
|
Hey @aiSynergy37, thanks for the contribution. I cherry-picked your commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #8699
Motivation and Context
N/A
Requires Documentation Change
N/A
How Has This Been Tested?
It was tested using unit tests.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>