refactor: remove deprecated OAuth authentication base classes#9337
Open
Romazes wants to merge 1 commit intoQuantConnect:masterfrom
Open
refactor: remove deprecated OAuth authentication base classes#9337Romazes wants to merge 1 commit intoQuantConnect:masterfrom
Romazes wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
Remove abstract/generic auth infrastructure superseded by the concrete implementations introduced in QuantConnect#9330 (LeanOAuthTokenHandler, LeanTokenHandler, LeanTokenCredentials): - Delete OAuthTokenHandler<TRequest, TResponse> - Delete abstract TokenHandler<T> base - Delete TokenCredentials (replaced by LeanTokenCredentials) - Delete abstract AccessTokenMetaDataRequest/Response base classes - Update XML documentation in LeanOAuthTokenHandler and LeanTokenHandler Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated OAuth authentication base classes superseded by the concrete
implementations introduced in #9330. Cleans up
Brokerages/Authentication/by deleting:OAuthTokenHandler.cs— genericOAuthTokenHandler<TRequest, TResponse>, replaced byLeanOAuthTokenHandlerTokenHandler.cs— abstractTokenHandler<T>, replaced byLeanTokenHandlerTokenCredentials.cs— replaced byLeanTokenCredentialsAccessTokenMetaDataRequest.cs— abstract base, replaced byOAuthTokenRequestAccessTokenMetaDataResponse.cs— abstract base no longer needed; expiry tracking moved into the handlerAlso updates XML documentation in
LeanOAuthTokenHandler.csandLeanTokenHandler.csto reference the new concrete types.
Related PRs
All new OAuth logic was implemented in PRs:
Related Issue
Follows up on #9330 — feat: add CreateOAuthTokenHandler factory to Brokerage base class
Motivation and Context
PR #9330 introduced the new concrete, non-generic authentication handlers as part of the
OAuth authentication failure shutdown feature. The old abstract/generic base classes
(
OAuthTokenHandler<TRequest, TResponse>,TokenHandler<T>, etc.) became dead codeand are removed here to keep the codebase clean.
Requires Documentation Change
No. The removed classes were internal infrastructure not referenced in public documentation.
How Has This Been Tested?
Verified the solution builds successfully after deletion. All callers of the deleted
classes were already migrated to the new concrete types in #9330.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>