Skip to content

Fix: RecWindow rate limit #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Jan 29, 2025

Description

New Message description when order was Invalid.
image

Related Issue

closes #43

Motivation and Context

Fix the specific bug and remove duplication in a code base.

Requires Documentation Change

N/a

How Has This Been Tested?

  • class BinanceFuturesRestApiClient -> GetAccountHoldings()
  • GetCashBalance()
  • GetOpenOrders()
  • PlaceOrder()
  • CancelOrder()

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes added the bug Something isn't working label Jan 29, 2025
@Romazes Romazes self-assigned this Jan 29, 2025
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Romazes Romazes merged commit 63cf799 into QuantConnect:master Jan 31, 2025
@Romazes Romazes deleted the fix-43-rec-window-rate-limit branch February 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp for this request is outside of the recvWindow.
2 participants