Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for all index types #136

Merged
merged 285 commits into from
May 14, 2024

Conversation

asmeurer
Copy link
Member

Extend the slices documentation to document all NumPy index types.

This still a work in progress.

The page is long and maybe should be split, but I can't figure out how to do
it in a clean way.
@asmeurer asmeurer marked this pull request as ready for review May 9, 2024 08:54
@asmeurer
Copy link
Member Author

asmeurer commented May 9, 2024

I think I'm finally ready to get some human feedback on this. If you want to review this, click "Click here to see a preview of the documentation." in the checks below (the page doesn't live update if I push new commits so be sure to always click it again to get the latest version). The thing to look at here is the "Guide to NumPy Indexing" on the left sidebar. Any and all feedback is welcome, whether small or broad.

One thing I'm not sure about is whether the "Multidimensional Indices" page should be split into multiple smaller pages. The page is long and I feel like it would be useful, but I'm not sure how to best do it without interrupting the flow and keeping the overall layout. I don't really want to create nested pages in the guide because they are confusing.

@asmeurer
Copy link
Member Author

It's going to be easier to get reviews on this if it's live. Feel free to comment on the diff of this PR.

@asmeurer asmeurer merged commit a58da36 into Quansight-Labs:main May 14, 2024
19 checks passed
@asmeurer
Copy link
Member Author

The page is live as a soft launch https://quansight-labs.github.io/ndindex//indexing-guide/index.html. Further updates are at #176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant