UI enhancements #123
Open
UI enhancements #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the broken streaming functionality for both code completions and code migration, and unifies the feedback UI across all features. ## Key Changes ### Streaming Fixes - **Fixed dynamic configuration loading**: Moved calls inside service methods to ensure settings changes are picked up at runtime - **Corrected stream processing logic**: Fixed the core issue in where streaming chunks were incorrectly processed, leading to broken text accumulation - **Added delta field support**: Updated type to include the optional field for incremental streaming updates - **Enhanced stream buffering**: Improved streaming logic with better buffering and error handling for incomplete chunks - **Added streaming support to migration**: Code migration now supports streaming when the setting is enabled ### UI/UX Improvements - **Unified feedback UI**: Migration feedback now uses the same CodeLens thumbs up/down icons as normal completions, providing a consistent user experience - **Removed modal dialogs**: Replaced the migration feedback dialog with inline CodeLens feedback icons - **Added debug command**: New 'Debug streaming configuration' command to help troubleshoot streaming issues ### Documentation & Testing - **Updated documentation**: Added migration feedback section to GETTING_STARTED.md - **Added test files**: Created test files for verifying streaming functionality - **Enhanced logging**: Added comprehensive logging throughout the streaming pipeline ## Files Modified - : Fixed core streaming logic - : Dynamic config loading and better error handling - : Dynamic config loading - : Added streaming support - : Enhanced stream buffering - : Unified feedback UI with CodeLens - : Added delta field to ModelPromptResponse - : Added debug command - : Updated documentation ## Verification - ✅ All compilation errors resolved - ✅ Build passes successfully - ✅ Both streaming and non-streaming modes functional - ✅ Migration feedback UI unified with completions - ✅ Configuration changes now take effect immediately Fixes streaming issues and provides a consistent, professional user experience across all extension features.
## UI/UX Improvements ### Unified Feedback System - Replace migration modal dialogs with inline CodeLens thumbs up/down icons - Create consistent feedback experience across completions and migration - Remove workflow interruptions from feedback collection ### Enhanced Status Bar Animations - Add prominent loading spinner right after model name during operations - Context-aware loading states (connecting, generating, streaming, processing) - Improved visual feedback with appropriate icons for each stage - Only show 'streaming' status when streaming is actually enabled ### Professional Visual Polish - Clean, consistent iconography throughout the extension - Better spacing and visual hierarchy in status displays - Proper integration with VS Code theme colors ## Key Changes - src/commands/migrateQiskitCode.ts: Unified feedback UI with CodeLens - src/statusBar/statusBar.ts: Enhanced loading animations and accurate status - src/services/qiskitMigration.ts: Improved streaming architecture - GETTING_STARTED.md: Updated documentation for new UI patterns Provides a consistent, professional user experience across all extension features.
|
Rushil Kakkad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant user interface and user experience improvements to the Qiskit Code Assistant, focusing on creating a unified, professional, and consistent experience across all extension features. The main enhancements include unified feedback mechanisms, enhanced loading animations, and improved visual consistency.
Summary of Changes
Unified Feedback System
Enhanced Status Bar Loading Animations
Visual Polish and Consistency
Documentation Updates
Type of change
How Has This Been Tested?
Manual Testing Performed
Unified Feedback System Testing
Enhanced Loading Animations Testing
Cross-Feature Consistency Testing