Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MPI and AFQMC on sulfur CPU CI runs #5237

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 21, 2024

Proposed changes

github CI has a lot of NOMPI variants. It is less critical to have NOMPI variants in self-host run variants.
AFQMC requires MPI. So I modified GCC11-NoMPI-MKL to GCC11-MPI-MKL-AFQMC

What type(s) of changes does this code introduce?

  • Other (please describe): adjust CI

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

N/A

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 21, 2024

Test this please

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 21, 2024

Do not merge. It is expected to fail until #5236 gets in.

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 21, 2024

Due to change to .github/workflows/ci-github-actions-self-hosted.yaml a force merge will be needed.

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the CI is usually bottlenecked by GPU testing, we can add more CPU variants in future, if desired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@prckent
Copy link
Contributor

prckent commented Nov 21, 2024

Will merge by hand since there is no point in CI testing...

@prckent prckent merged commit 60b085d into QMCPACK:develop Nov 21, 2024
21 of 23 checks passed
@ye-luo ye-luo deleted the cpu-mpi-afqmc branch November 21, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants