Skip to content

Commit

Permalink
remove is_zsa_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
YaoGalteland committed Mar 24, 2024
1 parent 613b840 commit 32c21b9
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions halo2_gadgets/src/sinsemilla/chip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ where
pub(super) generator_table: GeneratorTableConfig,
/// An advice column configured to perform lookup range checks.
lookup_config: LookupRangeCheckConfig<pallas::Base, { sinsemilla::K }>,
/// FIXME: add a proper comment
is_zsa_variant: bool,
_marker: PhantomData<(Hash, Commit, F)>,
}

Expand Down Expand Up @@ -183,8 +181,6 @@ where
table_range_check_tag: lookup.3,
},
lookup_config: range_check,
// FIXME: consider passing is_zsa_enabled to `configure` function explicitly
is_zsa_variant: lookup.3.is_some(),
_marker: PhantomData,
};

Expand All @@ -209,11 +205,7 @@ where
meta.create_gate("Initial y_Q", |meta| {
let q_s4 = meta.query_selector(config.q_sinsemilla4);

let y_q = if config.is_zsa_variant {
meta.query_advice(config.double_and_add.x_p, Rotation::prev())
} else {
meta.query_fixed(config.fixed_y_q)
};
let y_q = meta.query_fixed(config.fixed_y_q);

// Y_A = (lambda_1 + lambda_2) * (x_a - x_r)
let Y_A_cur = Y_A(meta, Rotation::cur());
Expand Down

0 comments on commit 32c21b9

Please sign in to comment.