Skip to content

Extract zsa (optimization) related changes into separate modules (...… #269

Extract zsa (optimization) related changes into separate modules (...…

Extract zsa (optimization) related changes into separate modules (...… #269

Triggered via push April 2, 2024 10:16
Status Failure
Total duration 3m 49s
Artifacts

ci.yml

on: push
Matrix: build
Matrix: test-32-bit
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

51 errors and 182 warnings
Rustfmt
left behind trailing whitespace
Rustfmt
left behind trailing whitespace
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/utilities_opt/cond_swap.rs#L209
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/utilities_opt/cond_swap.rs:209:35 | 209 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 209 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/sinsemilla.rs#L580
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/sinsemilla.rs:580:31 | 580 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 580 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/sinsemilla/merkle.rs#L251
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/sinsemilla/merkle.rs:251:31 | 251 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup.0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 251 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup.0, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
field `zsa` of struct `utilities::lookup_range_check::LookupRangeCheckConfig` is private: halo2_gadgets/src/sinsemilla/chip.rs#L166
error[E0616]: field `zsa` of struct `utilities::lookup_range_check::LookupRangeCheckConfig` is private --> halo2_gadgets/src/sinsemilla/chip.rs:166:25 | 166 | range_check.zsa.map(|zsa| zsa.table_range_check_tag), | ^^^ private field
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs#L217
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/ecc_opt/chip/mul_fixed/short.rs:217:35 | 217 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 217 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/ecc.rs#L767
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/ecc.rs:767:31 | 767 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 767 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this function takes 4 arguments but 3 arguments were supplied: halo2_gadgets/src/ecc/chip/mul_fixed/short.rs#L464
error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:464:35 | 464 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------- an argument of type `std::option::Option<halo2_proofs::plonk::TableColumn>` is missing | note: associated function defined here --> halo2_gadgets/src/utilities/lookup_range_check.rs:90:12 | 90 | pub fn configure( | ^^^^^^^^^ 91 | meta: &mut ConstraintSystem<F>, | ------------------------------ 92 | running_sum: Column<Advice>, | --------------------------- 93 | table_idx: TableColumn, | ---------------------- 94 | table_range_check_tag: Option<TableColumn>, | ------------------------------------------ help: provide the argument | 464 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table, /* std::option::Option<halo2_proofs::plonk::TableColumn> */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
field `zsa` of struct `utilities::lookup_range_check::LookupRangeCheckConfig` is private: halo2_gadgets/src/sinsemilla/chip.rs#L166
error[E0616]: field `zsa` of struct `utilities::lookup_range_check::LookupRangeCheckConfig` is private --> halo2_gadgets/src/sinsemilla/chip.rs:166:25 | 166 | range_check.zsa.map(|zsa| zsa.table_range_check_tag), | ^^^ private field
Bitrot check: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Bitrot check
could not compile `halo2_gadgets` (lib) due to 1 previous error
Bitrot check
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Book tests: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Book tests: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `table_range_check_tag` of struct `ZsaExtension` is private
Book tests
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Build target wasm32-unknown-unknown: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Build target wasm32-unknown-unknown: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `table_range_check_tag` of struct `ZsaExtension` is private
Build target wasm32-unknown-unknown
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Build target wasm32-wasi
The job was canceled because "wasm32-unknown-unknown" failed.
Build target wasm32-wasi: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Build target wasm32-wasi: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `table_range_check_tag` of struct `ZsaExtension` is private
Build target wasm32-wasi
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on ubuntu-latest with nightly features: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Test on ubuntu-latest with nightly features: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `table_range_check_tag` of struct `ZsaExtension` is private
Test on ubuntu-latest with nightly features
could not compile `halo2_gadgets` due to 2 previous errors
Test on ubuntu-latest with nightly features
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on ubuntu-latest: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `zsa` of struct `LookupRangeCheckConfig` is private
Test on ubuntu-latest: halo2_gadgets/src/sinsemilla/chip.rs#L166
field `table_range_check_tag` of struct `ZsaExtension` is private
Test on ubuntu-latest
could not compile `halo2_gadgets` due to 2 previous errors
Test on ubuntu-latest
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on windows-latest with nightly features
The job was canceled because "nightly_ubuntu-latest" failed.
Test on windows-latest with nightly features
The operation was canceled.
Test on macOS-latest with beta features
The job was canceled because "nightly_ubuntu-latest" failed.
Test on macOS-latest with beta features
The operation was canceled.
Test on windows-latest
The job was canceled because "nightly_ubuntu-latest" failed.
Test on windows-latest
The operation was canceled.
Test on macOS-latest with nightly features
The job was canceled because "nightly_ubuntu-latest" failed.
Test on macOS-latest with nightly features
The operation was canceled.
Test on macOS-latest
The job was canceled because "nightly_ubuntu-latest" failed.
Test on macOS-latest
The operation was canceled.
Test on windows-latest with beta features
The job was canceled because "nightly_ubuntu-latest" failed.
Test on windows-latest with beta features
The operation was canceled.
Test on ubuntu-latest with beta features
The job was canceled because "nightly_ubuntu-latest" failed.
Test on ubuntu-latest with beta features
The operation was canceled.
Test on i686-unknown-linux-gnu with beta features
Process completed with exit code 101.
Test on i686-unknown-linux-gnu with nightly features
The job was canceled because "beta" failed.
Test on i686-unknown-linux-gnu with nightly features
Process completed with exit code 101.
Test on i686-unknown-linux-gnu
The job was canceled because "beta" failed.
Test on i686-unknown-linux-gnu
Process completed with exit code 101.
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
rustfmt has failed to format. See previous 2 errors.
usage of `Iterator::fold` on a type that implements `Try`: halo2_proofs/src/dev.rs#L1066
warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_proofs/src/dev.rs:1066:30 | 1066 | ... .fold(Ok(()), |acc, res| acc.and(res)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L174
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
this bound is already specified as the supertrait of `ExactSizeIterator`: halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
assigning the result of `Clone::clone()` may be inefficient: halo2_proofs/src/poly/multiopen.rs#L208
warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
the borrowed expression implements the required traits: halo2_proofs/src/poly/domain.rs#L559
warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:559:20 | 559 | let xn = x.pow(&[8, 0, 0, 0]); | ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: halo2_proofs/src/poly/domain.rs#L549
warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:549:38 | 549 | points.push(domain.omega.pow(&[i, 0, 0, 0])); | ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |
the borrowed expression implements the required traits: halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the borrowed expression implements the required traits: halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
struct `PointIndex` is never constructed: halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^
trait `IndexedParallelIterator` is never used: halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
the item `TryInto` is imported redundantly: halo2_gadgets/src/utilities.rs#L253
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities.rs:253:9 | 253 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `Error` is imported redundantly: halo2_gadgets/src/utilities.rs#L247
warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities.rs:247:62 | 242 | use super::*; | -------- the item `Error` is already imported here ... 247 | plonk::{Any, Circuit, ConstraintSystem, Constraints, Error, Selector}, | ^^^^^
the item `Layouter` is imported redundantly: halo2_gadgets/src/utilities.rs#L245
warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities.rs:245:19 | 242 | use super::*; | -------- the item `Layouter` is already imported here ... 245 | circuit::{Layouter, SimpleFloorPlanner}, | ^^^^^^^^
the item `PrimeField` is imported redundantly: halo2_gadgets/src/utilities.rs#L243
warning: the item `PrimeField` is imported redundantly --> halo2_gadgets/src/utilities.rs:243:46 | 242 | use super::*; | -------- the item `PrimeField` is already imported here 243 | use group::ff::{Field, FromUniformBytes, PrimeField}; | ^^^^^^^^^^
the item `Field` is imported redundantly: halo2_gadgets/src/utilities.rs#L243
warning: the item `Field` is imported redundantly --> halo2_gadgets/src/utilities.rs:243:21 | 242 | use super::*; | -------- the item `Field` is already imported here 243 | use group::ff::{Field, FromUniformBytes, PrimeField}; | ^^^^^
the item `TryInto` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L512
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:512:15 | 512 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `PrimeFieldBits` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L11
warning: the item `PrimeFieldBits` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:5 | 11 | use ff::PrimeFieldBits; | ^^^^^^^^^^^^^^^^^^ 12 | 13 | use super::*; | -------- the item `PrimeFieldBits` is already imported here
the item `PhantomData` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L9
warning: the item `PhantomData` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:29 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^^^^ ... 13 | use super::*; | -------- the item `PhantomData` is already imported here
the item `TryInto` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L9
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:11 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `Error` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:60 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^ ... 13 | use super::*; | -------- the item `Error` is already imported here
the item `Column` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Column` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:21 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 13 | use super::*; | -------- the item `Column` is already imported here
the item `Advice` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Advice` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:13 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 13 | use super::*; | -------- the item `Advice` is already imported here
the item `Layouter` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L5
warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:29 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^ ... 13 | use super::*; | -------- the item `Layouter` is already imported here
the item `AssignedCell` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L5
warning: the item `AssignedCell` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:15 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^^^^^ ... 13 | use super::*; | -------- the item `AssignedCell` is already imported here
the item `Error` is imported redundantly: halo2_gadgets/src/utilities/decompose_running_sum.rs#L215
warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/decompose_running_sum.rs:215:49 | 210 | use super::*; | -------- the item `Error` is already imported here ... 215 | plonk::{Any, Circuit, ConstraintSystem, Error}, | ^^^^^
the item `ConstraintSystem` is imported redundantly: halo2_gadgets/src/utilities/decompose_running_sum.rs#L215
warning: the item `ConstraintSystem` is imported redundantly --> halo2_gadgets/src/utilities/decompose_running_sum.rs:215:31 | 210 | use super::*; | -------- the item `ConstraintSystem` is already imported here ... 215 | plonk::{Any, Circuit, ConstraintSystem, Error}, | ^^^^^^^^^^^^^^^^
the item `TryInto` is imported redundantly: halo2_gadgets/src/sinsemilla.rs#L493
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sinsemilla.rs:493:9 | 493 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sinsemilla/merkle.rs#L199
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sinsemilla/merkle.rs:199:15 | 199 | use std::{convert::TryInto, iter}; | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/spread_table.rs#L10
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/spread_table.rs:10:5 | 10 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L13
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:13:5 | 13 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/compression.rs#L12
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression.rs:12:5 | 12 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256.rs#L6
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon/primitives.rs#L3
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/primitives.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon/pow5.rs#L618
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:618:9 | 618 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon/pow5.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon.rs#L3
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `pallas` is imported redundantly: halo2_gadgets/src/ecc/chip/witness_point.rs#L155
warning: the item `pallas` is imported redundantly --> halo2_gadgets/src/ecc/chip/witness_point.rs:155:9 | 155 | use pasta_curves::pallas; | ^^^^^^^^^^^^^^^^^^^^ 156 | 157 | use super::*; | -------- the item `pallas` is already imported here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul_fixed/short.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs#L18
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul.rs#L7
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul.rs:7:5 | 7 | convert::TryInto, | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip.rs#L18
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here | = note: `#[warn(unused_imports)]` on by default
struct `Variable` is never constructed: halo2_proofs/benches/plonk.rs#L19
warning: struct `Variable` is never constructed --> halo2_proofs/benches/plonk.rs:19:16 | 19 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused doc comment: halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default
the item `TryInto` is imported redundantly: halo2_proofs/src/transcript.rs#L6
warning: the item `TryInto` is imported redundantly --> halo2_proofs/src/transcript.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryFrom` is imported redundantly: halo2_proofs/src/poly/multiopen.rs#L395
warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/poly/multiopen.rs:395:9 | 395 | use std::convert::TryFrom; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here
the item `ExactSizeIterator` is imported redundantly: halo2_proofs/src/plonk/permutation/prover.rs#L6
warning: the item `ExactSizeIterator` is imported redundantly --> halo2_proofs/src/plonk/permutation/prover.rs:6:23 | 6 | use std::iter::{self, ExactSizeIterator}; | ^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `ExactSizeIterator` is already defined here
the item `TryFrom` is imported redundantly: halo2_proofs/src/plonk/circuit.rs#L5
warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/plonk/circuit.rs:5:5 | 5 | convert::TryFrom, | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here
unused imports: `ParallelIterator`, `Scope`: halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
struct `Variable` is never constructed: halo2_proofs/tests/plonk_api.rs#L26
warning: struct `Variable` is never constructed --> halo2_proofs/tests/plonk_api.rs:26:16 | 26 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
the item `PrimeFieldBits` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L11
warning: the item `PrimeFieldBits` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:11:5 | 11 | use ff::PrimeFieldBits; | ^^^^^^^^^^^^^^^^^^ 12 | 13 | use super::*; | -------- the item `PrimeFieldBits` is already imported here
the item `PhantomData` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L9
warning: the item `PhantomData` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:29 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^^^^ ... 13 | use super::*; | -------- the item `PhantomData` is already imported here
the item `TryInto` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L9
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:9:11 | 9 | use std::{convert::TryInto, marker::PhantomData}; | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `Error` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Error` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:60 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^ ... 13 | use super::*; | -------- the item `Error` is already imported here
the item `Column` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Column` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:21 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 13 | use super::*; | -------- the item `Column` is already imported here
the item `Advice` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L6
warning: the item `Advice` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:6:13 | 6 | plonk::{Advice, Column, ConstraintSystem, Constraints, Error, Selector, TableColumn}, | ^^^^^^ ... 13 | use super::*; | -------- the item `Advice` is already imported here
the item `Layouter` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L5
warning: the item `Layouter` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:29 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^ ... 13 | use super::*; | -------- the item `Layouter` is already imported here
the item `AssignedCell` is imported redundantly: halo2_gadgets/src/utilities/lookup_range_check.rs#L5
warning: the item `AssignedCell` is imported redundantly --> halo2_gadgets/src/utilities/lookup_range_check.rs:5:15 | 5 | circuit::{AssignedCell, Layouter, Region}, | ^^^^^^^^^^^^ ... 13 | use super::*; | -------- the item `AssignedCell` is already imported here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/spread_table.rs#L10
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/spread_table.rs:10:5 | 10 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L8
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:8:5 | 8 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/message_schedule.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/message_schedule.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L13
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:13:5 | 13 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16/compression.rs#L12
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16/compression.rs:12:5 | 12 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256/table16.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256/table16.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/sha256.rs#L6
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/sha256.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon/primitives.rs#L3
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/primitives.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon/pow5.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon/pow5.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/poseidon.rs#L3
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/poseidon.rs:3:5 | 3 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul_fixed/short.rs#L1
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:1:5 | 1 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs#L18
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul_fixed/base_field_elem.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip/mul.rs#L7
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip/mul.rs:7:5 | 7 | convert::TryInto, | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `TryInto` is imported redundantly: halo2_gadgets/src/ecc/chip.rs#L18
warning: the item `TryInto` is imported redundantly --> halo2_gadgets/src/ecc/chip.rs:18:5 | 18 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here | = note: `#[warn(unused_imports)]` on by default
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L174
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
this bound is already specified as the supertrait of `ExactSizeIterator`: halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
assigning the result of `Clone::clone()` may be inefficient: halo2_proofs/src/poly/multiopen.rs#L208
warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |
the borrowed expression implements the required traits: halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
the borrowed expression implements the required traits: halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
struct `PointIndex` is never constructed: halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^
trait `IndexedParallelIterator` is never used: halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused doc comment: halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment
unused doc comment: halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default
the item `TryInto` is imported redundantly: halo2_proofs/src/transcript.rs#L6
warning: the item `TryInto` is imported redundantly --> halo2_proofs/src/transcript.rs:6:5 | 6 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryInto` is already defined here
the item `ExactSizeIterator` is imported redundantly: halo2_proofs/src/plonk/permutation/prover.rs#L6
warning: the item `ExactSizeIterator` is imported redundantly --> halo2_proofs/src/plonk/permutation/prover.rs:6:23 | 6 | use std::iter::{self, ExactSizeIterator}; | ^^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `ExactSizeIterator` is already defined here
the item `TryFrom` is imported redundantly: halo2_proofs/src/plonk/circuit.rs#L5
warning: the item `TryFrom` is imported redundantly --> halo2_proofs/src/plonk/circuit.rs:5:5 | 5 | convert::TryFrom, | ^^^^^^^^^^^^^^^^ --> /rustc/c1195518c8ad7f37d15ecb82f39dec3da97f9c2f/library/std/src/prelude/mod.rs:129:13 | = note: the item `TryFrom` is already defined here
unused imports: `ParallelIterator`, `Scope`: halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Bitrot check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Bitrot check
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
Bitrot check: halo2_proofs/src/multicore.rs#L16
unused import: `Scope`
Bitrot check: halo2_proofs/src/dev/cost.rs#L105
unused doc comment
Bitrot check: halo2_proofs/src/dev/cost.rs#L107
unused doc comment
Bitrot check: halo2_proofs/src/dev/cost.rs#L109
unused doc comment
Bitrot check: halo2_proofs/src/plonk/circuit.rs#L769
field `0` is never read
Bitrot check
`halo2_proofs` (lib) generated 5 warnings (run `cargo fix --lib -p halo2_proofs` to apply 1 suggestion)
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Book tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Book tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Intra-doc links
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Intra-doc links
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build target wasm32-unknown-unknown
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest with nightly features
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on ubuntu-latest with nightly features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest with nightly features
build failed, waiting for other jobs to finish...
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest
build failed, waiting for other jobs to finish...
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on i686-unknown-linux-gnu with beta features
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on i686-unknown-linux-gnu with beta features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/