Skip to content

Fix #791: HuggingFaceDataset doesn't shuffle the dataset #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuyuyan2717 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #791: HuggingFaceDataset doesn't shuffle the dataset #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16901f
Fix #741: ValueError in WordSwapChangeNumber._alter_number for negati…
Mar 4, 2026
c48e0da
Trigger CI workflows
Mar 4, 2026
e311c75
Fix #791: HuggingFaceDataset doesn't shuffle the dataset
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions textattack/datasets/huggingface_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def __init__(

self.shuffled = shuffle
if shuffle:
self._dataset.shuffle()
self._dataset = self._dataset.shuffle()

def _format_as_dict(self, example):
input_dict = collections.OrderedDict(
Expand Down Expand Up @@ -190,5 +190,5 @@ def __getitem__(self, i):
]

def shuffle(self):
self._dataset.shuffle()
self._dataset = self._dataset.shuffle()
self.shuffled = True
2 changes: 1 addition & 1 deletion textattack/transformations/word_swaps/word_swap_change_number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _alter_number(self, num):
"""Helper function of _get_new_number, replace a number with another
random number within the range of self.max_change."""
if num not in [0, 2, 4]:
change = int(num * self.max_change) + 1
change = abs(int(num * self.max_change)) + 1
if num >= 0:
num_list = np.random.randint(max(num - change, 1), num + change, self.n)
else:
Expand Down
Loading