[FIX] Sparse initial pivot #785
Merged
+75
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to test coo_array functionnality
… columns. Merge remote-tracking branch 'origin/master' into geomloss_update
- Added position tracking maps (_arc_to_out_pos, _arc_to_in_pos) for O(1) arc lookups - Modified nextOut() and nextIn() to use position maps instead of linear search
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 97.07% 97.07% -0.01%
==========================================
Files 107 107
Lines 22142 22156 +14
==========================================
+ Hits 21495 21507 +12
- Misses 647 649 +2 🚀 New features to boost your workflow:
|
rflamary
reviewed
Dec 16, 2025
RELEASES.md
Outdated
|
|
||
| #### New features | ||
| - Add support for sparse cost matrices in exact EMD solver `ot.emd` and `ot.emd2` (PR #778) | ||
| - Migrate backend from deprecated `scipy.sparse.coo_matrix` to modern `scipy.sparse.coo_array` API (PR #TBD) |
Collaborator
There was a problem hiding this comment.
Fix PR number above and add PR numebr here
RELEASES.md
Outdated
|
|
||
| #### Closed issues | ||
| - Add support for sparse cost matrices in EMD solver (PR #778, Issue #397) | ||
| - Fix O(n³) performance bottleneck in sparse bipartite graph arc iteration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
Sparse EMD solver was 10-40x slower than dense solver on full matrices due to O(n³) complexity bug in arc iteration. The
nextOut()andnextIn()methods insparse_bipartitegraph.hwere performing linear search through arc lists on every call during pivot selection.How has this been tested (if it applies)
PR checklist