Add Custom Logger and types for better data handling, type checking a… #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request – Strong Typing & Basic Logging Module
Hi team 👋,
This PR introduces two key improvements aimed at increasing the quality, maintainability, and robustness of the SDK:
1. 🧾 Added
types.py
for Strong Typing2. 🪵 Introduced a Basic Logging Module
LoggingConfig
) and a dedicated logger class (KKiaPayLogger
).🛠️ Why This Is Split
Initially, I intended to include a larger refactor (better flexibility, extensibility, robustness, and structural consistency) in this single PR.
However, to make review, testing, and discussion easier, I decided to split it into smaller, focused pull requests.
Upcoming PRs will include:
httpx
client.Looking forward to your feedback, and thank you! 🙏
— Einswilli