support HTML5 form attribute
#267
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By searching for input elements also outside the form tag itself, which belong to this form according to their `form` attribute. closes Pylons#8
JohaJung
force-pushed
the
html5_form_attr
branch
from
44a1bac to
625bca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically implements what was proposed by @IwanVosloo in #8. Find inputs outside the form tag itself by searching for input elements in the whole response HTML to their
formattribute.closes #8
This is my first PR in this repository, so if there are any style/workflow guidelines I did not recognize or misunderstood, please let me know and I'll try to improve :)