This repository was archived by the owner on Aug 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/ps 275 #100
Draft
kjawadDeveloper2
wants to merge
11
commits into
main
Choose a base branch
from
fix/PS-275
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix/ps 275 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/screens/describe_screen.dart # lib/utils/progress_bar_builder.dart
kjawadDeveloper2
commented
Aug 2, 2022
lib/easel_provider.dart
Outdated
| enabled: true, | ||
| extraInfo: kExtraInfo); | ||
|
|
||
| log("MY JSON: ${recipe.toProto3Json().toString()}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
lib/utils/constants.dart
Outdated
| const int kFileCompressQuality = 50; | ||
|
|
||
| const double kPrecision = 100000000000000000; | ||
| const double kPrecision = 10000000000000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check before changing is it used somewhere and this change doesnt effect any.
| } | ||
| } | ||
|
|
||
| extension ValueConverterToBigInt on String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this anywhere?
# Conflicts: # lib/easel_provider.dart # lib/screens/describe_screen.dart # lib/screens/price_screen.dart # lib/screens/publish_screen.dart # lib/utils/constants.dart # lib/utils/extension_util.dart # lib/widgets/audio_widget.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.