-
Notifications
You must be signed in to change notification settings - Fork 351
Refactor/base node simplification #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut models and composite model creation
…utput model generation
…dynamic output model
…mic output handling
… dynamic output handling
wow this is a major change … looks like a lot of interface breakage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
workflow_executor.py
file in thebackend/pyspur/execution
directory. The primary focus of these changes is to refactor the code to useBaseModel
frompydantic
instead of custom types, and to improve code readability and maintainability.Refactoring to use
BaseModel
:BaseNodeOutput
withBaseModel
throughout the file, including in function signatures and type hints. [1] [2] [3] [4] [5] [6] [7] [8]Code readability improvements:
TypeVar
for type safety.These changes enhance the overall structure and maintainability of the
workflow_executor.py
file while ensuring type safety and consistency in the codebase.