Dedicated us inputs scenarios #181

danielelerede-oet · 2025-02-12T16:58:35Z

Changes proposed in this Pull Request

This PR builds on #172, and dedicated US inputs are further improved:

different scenarios are taken into account for electrolyzers and DAC costs, building on the nomenclature by the NREL ATB (Conservative, Moderate, Advanced)
inflation rates (generally applied to all cost values) are taken into account for values in EUR only, as the US-specific data should already consider adjustment for inflation.

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
Data source for new technologies is clearly stated.
Newly introduced dependencies are added to environment.yaml (if applicable).
A note for the release notes doc/release_notes.rst of the upcoming release is included.
I consent to the release of this PR's code under the GPLv3 license.

…o create_dedicated_us_inputs

…only

fneum · 2025-02-18T09:24:01Z

This might now require a rebase.

danielelerede-oet · 2025-02-18T11:01:48Z

Hi @fneum , in response to your comment on inflation rate on #172, here the processing of costs expressed in USD is removed as the NREL ATB and ICCT dataset for electrolysis technologies already consider the adjustment for inflation. We agree anyway about the need for a US-dedicated dataset for inflation to be applied, for instance, on Fischer-Tropsch and DAC, whose values are not adjuster for inflation.

…ows where scenario is defined

…o dedicated_us_inputs_scenarios

finozzifa · 2025-03-04T14:40:28Z

hey @lkstrp, the PR is ready to be reviewed.

euronion

Thanks for the PR! 👍

Comments:

Any reason for the reorder in the manual_input_usa.csv? Since the rows were reordered, I couldn't figure out which ones changed or didn't. So I didn't go through all of them again and only picked a few random ones... . (Hint for next time to better not reorder the files :) )
It would be helpful to document the new columns and their meaning. I don't think we yet have a doc on the manual_input.csv (in general) -> We should open a issue for documentation on that. Can you add here what your understanding about the two columns is?
When running snakemake compile_cost_assumptions_usa I get the following a warning 7 times. Please address or suppress the warning if not relevant:

/home/user/.vscode-micromamba/envs/technology-data/lib/python3.12/site-packages/openpyxl/styles/stylesheet.py:237: UserWarning: Workbook contains no default style, apply openpyxl's default
  warn("Workbook contains no default style, apply openpyxl's default")

outputs/US/costs_2020.csv

euronion · 2025-03-11T12:49:18Z

outputs/US/costs_2020.csv

-Alkaline electrolyzer,FOM,0.04,%/year,ICCT IRA e-fuels assumptions ,,2022.0,,
+Alkaline electrolyzer,FOM,0.04,%/year,ICCT IRA e-fuels assumptions ,,2022.0,"R&D; and
+Market",Moderate
+Alkaline electrolyzer,FOM,0.04,%/year,ICCT IRA e-fuels assumptions ,,2022.0,"R&D; and


I recommend to stick to a consistent nomenclature for newly added entries:

either all lower case or Sentence case for words

all CAPITAL CASE for acronyms

outputs/US/costs_2025.csv

inputs/US/manual_input_usa.csv

scripts/compile_cost_assumptions_usa.py

euronion · 2025-03-11T13:27:38Z

scripts/compile_cost_assumptions_usa.py

    # Correct the cost assumptions to the inflation rate
-    inflation_adjusted_manual_input_usa_file_df = adjust_for_inflation(
-        inflation_rate_series,
-        manual_input_usa_file_df,
-        manual_input_usa_file_df.technology.unique(),
-        eur_year,
-        "value",
-        usa_costs_flag=True,
+    mask = manual_input_usa_file_df["unit"].str.startswith("EUR", na=False)
+
+    inflation_adjusted_manual_input_usa_file_df = manual_input_usa_file_df.copy()
+    inflation_adjusted_manual_input_usa_file_df.loc[mask, "value"] = (
+        adjust_for_inflation(
+            inflation_rate_series,
+            manual_input_usa_file_df.loc[mask],
+            manual_input_usa_file_df.loc[mask, "technology"].unique(),
+            eur_year,
+            "value",
+            usa_costs_flag=True,
+        )["value"]
    )


So the assumption here is that EUR values need to be adjusted for inflation, USD values not?
That seems to be provoking errors for future additions with USD values that are not inflation adjusted and will break when changing the cost reference year.

Why not use the currency_year we used in the original manual_input.csv to have the inflation adjustments done automatically?

We also faced this issue. It would be indeed a good idea to have an input file for US inflation rates. By the way, the sources we used for costs report that their values are already adjusted for inflation, so we removed this further step for US-specific data.

Inflation adjustment is not a one time thing.
The sources might have accounted for inflation to get all values into e.g. USD-2023 values.
The purpose of inflation adjustment however is to get from the reported curency year to the requested currency year, e.g. USD-2020 or USD-2025.

Thank you @euronion! This is what I read on the data source (https://atb.nrel.gov/electricity/2024/financial_cases_&_methods)

Do you think we need to include inflation rate adjustment for USD values, too?

The document you are referring to

[...] focuses on the input variables to the weighted average cost of capital (WACC)

which is not related to your data!

What you are actually interested in is the following definition or the "Dollar Year"

So yes, you need to include a currency year and you need to enable inflation adjustments.

…en-energy-transition/technology-data into dedicated_us_inputs_scenarios

danielelerede-oet · 2025-03-12T11:59:58Z

Hi @euronion , thank you for reviewing the PR! :)

Concerning your initial questions:

The reason for the reordering was due to the addition of scenario and financial case for electrolyzer technologies, which was the main change in manual_input_usa.csv. I performed a new reordering to have all technology groups in a logical order after the addition of the new columns
Concerning the documentation @finozzifa already worked on that in Update documentation #186 . Just to clarify, the two columns consider the same nomenclature of cost scenarios as in the NREL ATB. In particular, the scenario column (Conservative, Moderate, Advanced) is required to implement the different technology advancement scenarios as from the figure:

financial_case is needed to include differences due to the presence of production tax credits (addressed in Add US production tax credits input file #183): R&D only corresponds to a cost scenario without tax credits, while Market to a cost scenario with the application of production tax credits from US Tax Credit Guidances (Work in Progress, we're in contact with ICCT for the final overview on the application of tax credits).
@finozzifa is taking care of the warnings

euronion · 2025-03-12T13:51:20Z

The reason for the reordering was due to the addition of scenario and financial case for electrolyzer technologies, which was the main change in manual_input_usa.csv. I performed a new reordering to have all technology groups in a logical order after the addition of the new columns

Much better for reviewing, thanks!
For future we should fix the sort order once and then not change it anymore, not only for easier viewing, but also for spotting accidental modifications.

Concerning the documentation @finozzifa already worked on that in Update documentation #186 . Just to clarify, the two columns consider the same nomenclature of cost scenarios as in the NREL ATB. In particular, the scenario column (Conservative, Moderate, Advanced) is required to implement the different technology advancement scenarios ...

I see. For me it is good enough to just get the NREL ATB description for "scenario" in here, for the financial_case the description you provided is already enough for me. :)

inputs/US/manual_input_usa.csv

euronion · 2025-03-14T10:26:28Z

@finozzifa and @danielelerede-oet will open a separate PR to address inflation adjustments for US

finozzifa and others added 26 commits January 27, 2025 12:24

code: introduce dedicated inputs and folders for the US

82ac5da

code: add manual input usa

df1761e

code: latest changes to compile_cost_assumptions_usa.py

6ff2f6c

code: latest changes to compile_cost_assumptions_usa.py - 2

fa53daa

code: relocate adjust_for_inflation to _helpers.py

7bc1619

code: update costs in manual_input.csv

6de5d2a

code: next step on compile_cost_assumptions_usa.py

c92def7

code: updates

d1c4791

code: add docstring

5d214e4

code: pre-commit

55990ec

code: new updates to docstring

e02eec0

code: docstring

f109fed

code: docstring in _helpers.py

9b5a5aa

docu: update the release notes

edf5f70

code: add unit tests

41baba6

code: add pre-commit

5cbe314

Merge branch 'master' of https://github.com/PyPSA/technology-data int…

082d710

…o create_dedicated_us_inputs

code: sort outputs

ea373e7

code: add pre-commit

0e77e31

merge from master

cafe5fb

doc: add docstring

f492d7b

code: merge from master

874102e

code: re-import numpy and pandas in _helpers.py

3cbc206

add scenarios for H2 and DAC (US only) + apply inflation rate to EUR …

a445edf

…only

doc: update release notes

27acc62

code: fix unit tests

1c2d04e

code-data: merge from master

2dfbab9

data: modify manual_input_usa.csv specifying financial_case R&D for r…

7cb77e0

…ows where scenario is defined

finozzifa mentioned this pull request Feb 19, 2025

Consider NREL ATB cost database #46

Closed

finozzifa added 3 commits February 19, 2025 14:51

code: merge from master

fbc64ce

Merge branch 'master' of https://github.com/PyPSA/technology-data int…

dc01499

…o dedicated_us_inputs_scenarios

code: merge from master

48d15ad

add missing scenarios for electrolyzers

da782e1

lkstrp requested a review from euronion March 6, 2025 07:41

finozzifa and others added 4 commits March 10, 2025 10:30

code: merge from master

5a602a8

Merge branch 'master' into dedicated_us_inputs_scenarios

ca7c084

Merge branch 'master' into dedicated_us_inputs_scenarios

78367f6

pre-commit changes

157ae02

euronion requested changes Mar 11, 2025

View reviewed changes

finozzifa and others added 4 commits March 12, 2025 11:59

merge from master

927fcef

reorder manual_input_usa.csv

0a05018

add new files

9efff5a

Merge branch 'dedicated_us_inputs_scenarios' of https://github.com/op…

0312582

…en-energy-transition/technology-data into dedicated_us_inputs_scenarios

euronion mentioned this pull request Mar 12, 2025

Add calamine as engine for reading Excel files #190

Merged

5 tasks

finozzifa and others added 7 commits March 12, 2025 15:25

Merge branch 'master' into dedicated_us_inputs_scenarios

e5c4065

fix financial case for ICCT technologies

853b641

ensure that financial case is correctly reported in output files

923e23e

update unit test

e278bf4

modify representative NREL technologies

3b5a549

include description of scenario and financial case

4419e62

code: resolve FutureWarning from set_specify_assumptions

7ae749a

euronion self-requested a review March 14, 2025 10:14

euronion approved these changes Mar 14, 2025

View reviewed changes

inputs/US/manual_input_usa.csv Show resolved Hide resolved

euronion merged commit 8dc5787 into PyPSA:master Mar 14, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dedicated us inputs scenarios #181

Dedicated us inputs scenarios #181

danielelerede-oet commented Feb 12, 2025

fneum commented Feb 18, 2025

danielelerede-oet commented Feb 18, 2025

finozzifa commented Mar 4, 2025

euronion left a comment

euronion Mar 11, 2025

euronion Mar 11, 2025

danielelerede-oet Mar 12, 2025

euronion Mar 13, 2025

danielelerede-oet Mar 13, 2025

euronion Mar 13, 2025

danielelerede-oet commented Mar 12, 2025 •

edited

Loading

euronion commented Mar 12, 2025

euronion commented Mar 14, 2025

Dedicated us inputs scenarios #181

Dedicated us inputs scenarios #181

Conversation

danielelerede-oet commented Feb 12, 2025

Changes proposed in this Pull Request

Checklist

fneum commented Feb 18, 2025

danielelerede-oet commented Feb 18, 2025

finozzifa commented Mar 4, 2025

euronion left a comment

Choose a reason for hiding this comment

euronion Mar 11, 2025

Choose a reason for hiding this comment

euronion Mar 11, 2025

Choose a reason for hiding this comment

danielelerede-oet Mar 12, 2025

Choose a reason for hiding this comment

euronion Mar 13, 2025

Choose a reason for hiding this comment

danielelerede-oet Mar 13, 2025

Choose a reason for hiding this comment

euronion Mar 13, 2025

Choose a reason for hiding this comment

danielelerede-oet commented Mar 12, 2025 • edited Loading

euronion commented Mar 12, 2025

euronion commented Mar 14, 2025

danielelerede-oet commented Mar 12, 2025 •

edited

Loading