add PyUntypedBuffer
#5458
Open
add PyUntypedBuffer
#5458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to make a first step towards resolving #5245
The idea is to add
PyUntypedBuffer, which is a sibling toPyBuffer<T>which does not care about the actual element type it holds inside. I got the idea of the name fromPyUntypedArrayinrust-numpy.I can imagine that this is potentially applicable in a number of cases where the user wants to attempt to get a buffer export from an object but doesn't necessarily know what element type the object will export.
PyUntypedBuffer::get()can be used to get the export,.format()can then be inspected to deduce what concrete elementTto cast the buffer to.I think while we're here I moved a lot of the implementations of methods from
PyBuffer<T>toPyUntypedBuffer, which may slightly reduce generic code bloat.