Conversation
SemTiOne
commented
Sep 10, 2026
SemTiOne
commented
- Fix Incosistent sorting of wrapped imports with --force-sort-within-sections #1985
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Opening-line comments discard subsequent imported names from the new sort key.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes inconsistent ordering between wrapped and unwrapped imports when force-sorting sections.
Changes:
- Normalizes rendered imports before calculating sort keys.
- Adds regression coverage for wrapping, comments, length sorting, and idempotency.
| File | Description |
|---|---|
isort/output.py |
Adds logical-line normalization for section sorting. |
tests/unit/test_regressions.py |
Adds issue #1985 regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2656 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 41 41
Lines 3217 3224 +7
Branches 691 691
=======================================
+ Hits 3199 3206 +7
Misses 11 11
Partials 7 7 🚀 New features to boost your workflow:
|
Member
|
Superseded by #2667, thanks for the initial fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.