fix: keep comment-only lines inside from-import groups

[l46983284-cpu]

Summary

Comment-only lines inside a parenthesised from … import ( group were collapsed onto the opening import line as one semicolon-joined comment. With the black profile that rewrote intentional WIP comments and produced lines that fail line-length checkers.

This change tracks those body comments separately. When parentheses are used, they are re-emitted as their own indented comment lines inside the group. Non-parenthesised wrap modes keep the historical collapse behaviour so existing cases such as issue 1396 stay stable.

Test plan

• pytest tests/unit/test_regressions.py::test_comment_only_lines_in_from_import_group_issue_1852
• pytest tests/unit/test_regressions.py::test_incorrect_grouping_when_comments_issue_1396
• pytest tests/unit/test_regressions.py::test_comment_on_opening_line_of_aliased_import_does_not_move
• pytest tests/unit/test_isort.py tests/unit/test_regressions.py tests/unit/test_comments.py (331 passed, 1 skipped)

Fixes #1852

[l46983284-cpu]

DeepSource was failing because the existing skipcq: PY-R1000 comment landed on the small helper I added instead of _with_from_imports.

Moved the skip back onto _with_from_imports (same pattern as before). No product change; regression for #1852 still passes.

[codecov]

Codecov Report

❌ Patch coverage is 94.91525% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.22%. Comparing base (bae1e55) to head (0e3cd7e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
- Coverage   99.30%   99.22%   -0.09%     
==========================================
  Files          41       41              
  Lines        3153     3207      +54     
  Branches      681      696      +15     
==========================================
+ Hits         3131     3182      +51     
- Misses         14       15       +1     
- Partials        8       10       +2     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[l46983284-cpu]

Fixed flake8 E303 by removing one extra blank line before the #1852 regression test. No product change.

[l46983284-cpu]

Lint Attempt #2 failed on ruff format --check for tests/unit/test_regressions.py (not flake8 E303). Applied ruff format to the #1852 regression test only; product behavior unchanged. Focused pytest still passes.

[l46983284-cpu]

Residual loop closeout (multi-stage A/C/D/B1/B2 + mechanical gate PASS):

• Fixed force_single_line silent drop of from_body comments (now attaches to first single-line import, main-compatible).
• Fixed combine_star orphan indented body comments (fold onto star statement).
• Added regressions for both paths; primary black Comments in group imports are moved to a single line causing line too long violation (black, flake8) #1852 + Commented Import sorting #1396 still green.
• Head includes 123e7d3 after prior style residuals.

No further product thrash planned; remaining secondary nits (as-only / all-comment-only) disclosed as ALLOW_WITH_NITS scope.

[l46983284-cpu]

Quick update without the process noise from my last note:

I fixed two edge cases on the current head: force_single_line was dropping body comments, and combine_star left orphan indented comments. Both have regression tests, and the original #1852 black-profile case still passes.

No further product thrash planned from me. Happy to adjust if review wants a different default.

[DanielNoord]

Please ensure the full patch has coverage :)

For the tests I'd prefer the style of the first test so making explicit what the final output looks like instead of using "..." in out. However, if the output is the same as the input please use something like assert isort.code(to_sort, profile="black", line_length=100) == to_sort

[l46983284-cpu]

Thanks — I rewrote the #1852 tests to use explicit expected output (including the force_single_line case) and added coverage for the remaining from_body / inject branches.

[DanielNoord]

Can you fix CI to pass? I'll have a look at this afterwards :)

[DanielNoord]

CI still isn't fixed.

[l46983284-cpu]

Rebased onto main (kept the new alias-comment regression), fixed the lint/format gap, and closed the from_body drops on as-only / force_single emit paths. Local unit suite + mypy/flake8/ruff/hug check are green on this tip.

[DanielNoord]

We're missing coverage again.

[l46983284-cpu]

Thanks — added coverage for the remaining from_body inject branches (ignore_comments, nested-merge fold, and force_single plain-before-as). No product change on this tip.