feat: rectangular mesh split — Bilinear pins regenerated, RTU pin copies kept - #259
Merged
Merged
Conversation
…ies kept Follow-up to PyAutoArray#462 (rectangular Bilinear/RTU mesh split, task PyAutoArray#461): - Imaging/multi_dataset jax_likelihood rectangular* scripts switch to the RectangularBilinear* default; likelihood pins regenerated (JAX_ENABLE_X64=1): imaging -644121.021562 -> -651692.997799; imaging mge -11.65793201 -> -85.41696632; imaging dspl -3823.887477 -> -3695.93899659 (bandwidth kwarg dropped — the rank CDF has no bandwidth; see the RTU copy); multi_dataset -8903.89296045 -> -12932.06852498; multi_dataset mge -3810.18711583 -> -6157.55707862. - New rectangular*_rtu.py copies of those five pin scripts keep the kernel-CDF meshes pinned under the RectangularRTU* names — pure renames, pin values unchanged (imaging and dspl copies re-verified green). - Interferometer, jax_grad and sparse-operator scripts: pure rename to the RectangularRTU* names (behaviour and pins unchanged; interferometer/jax_likelihood/rectangular.py re-verified green incl. the TransformerNUFFT cross-check). - Other imaging-family scripts (visualization, model_fit, convolution, datacube docs, database scrape) follow the workspace default -> Bilinear. - scripts/misc/aggregator prior yaml: stale "rectangular.<Class>" key (never resolved — autonerves matches the real module path via endswith) rekeyed to rectangular_bilinear_adapt_density.* and rectangular_rtu_adapt_density.*. - scripts/CLAUDE.md coverage table updated. Verified against merged PyAutoArray main: all five Bilinear pin scripts, rectangular_dspl_rtu.py, and interferometer/jax_likelihood/rectangular.py pass end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtMqU3JfmyJh8GvB7jT4Et
Jammy2211
added
the
pending-release
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_testfollow-up to the PyAutoArray rectangular mesh split (PyAutoLabs/PyAutoArray#462, merged; task PyAutoLabs/PyAutoArray#461; siblings PyAutoLabs/autolens_workspace#495, PyAutoLabs/autogalaxy_workspace#221). Imaging/multi_dataset pin scripts switch to the Bilinear default with regenerated likelihood pins; RTU (kernel-CDF) coverage survives via pure-rename copies with unchanged pins; interferometer/gradient/sparse scripts are pure RTU renames.Scripts Changed
imaging/jax_likelihood/rectangular{,_dspl,_mge}.py,multi_dataset/jax_likelihood/rectangular{,_mge}.py: →RectangularBilinear*, pins regenerated (run underJAX_ENABLE_X64=1against merged PyAutoArray main):-644121.021562→-651692.997799-11.65793201→-85.41696632-3823.887477→-3695.93899659(thebandwidth=0.1kwarg is dropped — the rank CDF has no bandwidth; the RTU copy keeps it)-8903.89296045→-12932.06852498-3810.18711583→-6157.55707862rectangular*_rtu.pycopies of those five scripts keep the kernel-CDF meshes pinned under theRectangularRTU*names — pure renames, pin values unchanged.interferometer/**,imaging/jax_grad/**,misc/jax_assertions/sparse_operators.py: pure rename toRectangularRTU*(behaviour and pins unchanged — RTU is the gradient/interferometer mesh).RectangularBilinear*.misc/aggregator/config/priors/pixelizations.yaml: stalerectangular.<Class>key rekeyed to the resolving module-path form (both Bilinear and RTU entries).scripts/CLAUDE.mdcoverage table updated.Upstream PR
Test Plan
jit(fit_from)/jit(log_likelihood_function)round-trips).rectangular_rtu.pyandrectangular_dspl_rtu.pypass with their unchanged pins (pure-rename check).interferometer/jax_likelihood/rectangular.pypasses unchanged, including the mass-sensitivity floor andTransformerNUFFTcross-check.JAX_ENABLE_X64=1; the bare-container float32 vmap gives-inffor these scripts even on unmodifiedmain(pre-existing environment trait, unrelated to this change).Generated by Claude Code