refactor: remove dead non_linear config files (PyAutoBrain#155) - #9
Merged
Conversation
config/non_linear/{nest,mle,mcmc}.yaml is dead config — nothing reads
conf.instance["non_linear"] for them. Non-linear searches take their defaults
from their Python constructor signatures (e.g. Nautilus n_live=3000 in
autofit/non_linear/search/nest/nautilus/search.py), while these yamls say
n_live=200 and have no effect. No library ships them; the only live file in
this directory is GridSearch.yaml (kept). The user-facing workspaces already
dropped them; this clears the stale test/assistant/developer/euclid copies.
Same defect class as the grids.yaml removal (autolens_workspace#317); found by
the reachability-based orphan-config-file check added in PyAutoBrain (issue
PyAutoBrain#155).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of PyAutoBrain#155 — removes dead orphan config surfaced by the new reachability-based
/hygiene configcheck.config/non_linear/{nest,mle,mcmc}.yamlis dead: nothing readsconf.instance["non_linear"]for them. Non-linear searches take their defaults from their Python constructor signatures (Nautilusn_live=3000inautofit/non_linear/search/nest/nautilus/search.py), while these yamls sayn_live=200and have no effect. No library ships them; the only live file in the directory isGridSearch.yaml, which stays.Same defect class as the
grids.yamlremoval (autolens_workspace#317). Verified after deletion thatconf.instance["non_linear"]still resolves (gridsearchkept) and config loading is unbroken.