Repository navigation
feat: warn when PointSolver extent approaches observed positions - #764
Merged
Merged
Conversation
Collaborator
Author
|
Workspace companion: PyAutoLabs/autolens_workspace_test#338. Campaign record: PyAutoLabs/autolens_profiling#363. Human acknowledged the reported Heart YELLOW development checkpoint via “prm and continue”. Library-first and workspace release gates remain in force. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a construction-time PointSolver extent diagnostic to
AnalysisPoint, implementing the next single-source CPU campaign member. Warn when observed positions lie outside or within2 * initial scale + 3 * position sigmaof any grid edge. Explain that observed-position coverage does not prove image completeness across the model prior.Emit an INFO performance hint only when both solver half-widths exceed three times the padded observed envelope about the grid midpoint. Suppress that hint in test/small-dataset mode. Preserve custom/mock solvers without extent metadata and absent diagnostic inputs.
API Changes
No signature, return value, solver default, or likelihood-path changes.
AnalysisPointnow logs once at construction: WARNING for insufficient observed-position coverage, INFO for a substantially oversized grid. The latter is suppressed in test/small-dataset mode. No migration required.Test Plan
-83.38049778vmap pin (rtol 1e-4), JIT/NumPy parity and no diagnostic logs during repeated likelihood evaluations.Campaign scope
Single-source only. No extent, scale or MAX_CONTAINING_SIZE defaults change. Per-package extent choices remain a separate phase.
Refs #763. Companion workspace and campaign-record PRs will be linked here.