Repository navigation
fix: save_results survives a rejected max-likelihood sample (PyAutoFit#1535) - #713
Merged
Merged
Conversation
…-likelihood tracer (PyAutoFit#1535)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis.save_resultswrites the optionaltracer.jsonfromresult.max_log_likelihood_tracerinside atrythat caught onlyAttributeError. When the stored best point is rejected by the model, PyAutoFit raisesSamplesException/FitExceptionthere, which escapedstart_resume_fitbeforepaths.completed()and killed six completed A100 fits (PyAutoLabs/autolens_profiling#182; root fix in PyAutoLabs/PyAutoFit#1535's PR). The catch is widened and logs a warning instead of silently passing.Companion to the PyAutoFit PR; safe to merge independently.
API Changes
None.
save_resultsnow logs a warning and continues when the maximum-likelihood tracer cannot be built, instead of raising.See full details below.
Test Plan
pytest test_autolens -q— 553 passedsave_resultsswallowsAttributeError,af.exc.SamplesException,af.exc.FitExceptionfrommax_log_likelihood_tracerFull API Changes (for automation & release notes)
Removed
Added
Migration
Generated by the PyAutoLabs agent workflow.