Repository navigation
fix: resolve configured priors for plain function models - #1705
Merged
Merged
Conversation
Jammy2211
added
the
pending-release
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plain functions reached the class-prior lookup as None and could not build default priors. Resolve their own config path, report missing configuration clearly, and construct function results directly while preserving the existing class-method path.
Closes #1702.
API Changes
af.Model(function)now resolves function defaults using the existing module/name config layout. Missing function configuration raises an actionable ConfigException. Both normal and frozen function models evaluate correctly. Class and initializer-method behavior is preserved. See full details below.Test Plan
Full API Changes (for automation & release notes)
Changed Behaviour
Model.make_prior: standalone functions use their own config entry; missing defaults raise ConfigException with an explicit-prior remedy.Model._instance_for_arguments: standalone functions are called directly; class initializer methods keep their owner allocation path.Migration
No signature or output-identifier changes. No existing model/search folders renamed. No downstream script changes required.
Workflow
Human review and
/prmrequired; no merge authorized. Heart readiness STALE: CI unavailable to local Heart collector, no test-run report, install verification or release validation. This is development, not release readiness. Ordinary user-authorized workflow; no independent-review claim.Generated by the PyAutoLabs agent workflow.