Repository navigation
refactor: promote search-zip preservation to a public paths method #1389
Description
Overview
_append_to_search_zip (private, in autogalaxy/analysis/adapt_images/adapt_images.py, cross-imported by autolens/analysis/result.py) appends post-completion cache files into a search's .zip so paths.restore() — which deletes the output dir and re-extracts the zip — cannot destroy them on the next resume. That concern belongs to the paths layer: any code writing artifacts into a completed search's files/ needs it (born in PyAutoGalaxy#502 / autolens_profiling#70).
Plan
- PyAutoFit: public
AbstractPaths.preserve_in_zip(file_path)— no-op when the zip is absent; skip when the member already exists; arcname relative tooutput_path. Unit test: write into a zipped search'sfiles/, preserve,restore(), assert survival. - PyAutoGalaxy: call
result.paths.preserve_in_zip(...); delete the private helper. - PyAutoLens: call
self.paths.preserve_in_zip(...); delete the cross-import. - PRs ordered PyAutoFit → PyAutoGalaxy → PyAutoLens; behaviour identical throughout.
Suggested branch: feature/preserve-in-zip
Activity
Merge pull request #1390 from PyAutoLabs/feature/preserve-in-zip
Jammy2211 commentedon Jul 17, 2026
Phase 1 shipped — 2026-07-17
AbstractPaths.preserve_in_zip+ tests (suite 1499p/1s).Phase 2 (remaining, blocked): switch callers and delete the private helper once
potential-correction-portfrees PyAutoGalaxy/PyAutoLens:adapt_images.py→result.paths.preserve_in_zip(cache_path); delete_append_to_search_zip.result.py→self.paths.preserve_in_zip(cache_path); drop the autogalaxy cross-import..completedstopgap inautolens_profiling/pipeline_resume/slam_resume.py(no-op since PyAutoFit#1388) oncecompile-census-finalfrees that repo — same cleanup batch.Jammy2211 commentedon Jul 17, 2026
Phase 2 shipped — 2026-07-17, all riders closed
paths.preserve_in_zip; private_append_to_search_zipdeleted (991p)..completedstopgap removed (no-op since fix: mark test-mode bypassed fits complete so they are resumable (#1387) #1388); post-fast-path reference recorded — cold 159s → any resume ~11–13s (even the first resume is fast: the cold run writes the caches itself). Also fixes 2 pre-existing CI-blocking ruff errors on main.Everything in this issue's checklist is done.