Add python 3.8 #347
Open
Add python 3.8 #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot of the latest versions of packages rely on Python 3.9+. This means this PR may result in lack of capabilities when using 3.8, and it makes lockfiles much larger since we now need to also track two resolutions for each package that no longer supports 3.8, ballooning the lockfile from 1MB to 1.7MB. Why not bump the required Python version from where you're using it? |
|
I know, and I wish I could. Unfortunately, Isaac Gym, which has long been deprecated but appears to be relevant for another year or two, only supports up to Python 3.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in python 3.8, and it worked. Would like to pip install pufferlib for IsaacGym. Thanks!