Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to import external dependencies from the shared module #179

Open
maurizi opened this issue Jun 10, 2020 · 1 comment
Open

Add ability to import external dependencies from the shared module #179

maurizi opened this issue Jun 10, 2020 · 1 comment

Comments

@maurizi
Copy link
Contributor

maurizi commented Jun 10, 2020

Detailed Description

In #177 I tried to add types to a module in shared that were aliases of geojson types.

However, because the shared module is outside of the root directory when accessed from the server, it does not have a node_modules directory and TypeScript cannot find any external modules.

@maurizi
Copy link
Contributor Author

maurizi commented Jun 10, 2020

I worked-around this in development by symlinking the node_modules directory for server into shared, but that doesn't seem like an ideal solution.

Some potential options are:

maurizi added a commit that referenced this issue Apr 2, 2021
This is still not perfect due to #179, but its a lot better
maurizi added a commit that referenced this issue Apr 5, 2021
This is still not perfect due to #179, but its a lot better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants