Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vendored difflib library npm dependency #232

Open
maurizi opened this issue Jul 28, 2020 · 0 comments
Open

Replace vendored difflib library npm dependency #232

maurizi opened this issue Jul 28, 2020 · 0 comments

Comments

@maurizi
Copy link
Contributor

maurizi commented Jul 28, 2020

Description

As part of porting the password validation strategy from Temperate, we copied over a vendored & modified version of difflib, a Javscript port of a Python utility used by Django's password validation.

We'd prefer to not include a vendored library for this, and we don't particularly need to use difflib like we did in Temperate, but password validation is used on both the frontend & backend and until #179 is fixed we can't import any npm dependencies into the shared module.

AC

  • The vendored difflib module is removed, and replaced with an equivalent dependency from NPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants