Consuming buckets for custom PG

src_new/config.js

@@ -292,7 +292,24 @@ exports.isReduceCodeSizeFeatureEnabled = function(){
 };
 // endRemoveIf(removeAlways)
 exports.getPriceGranularity = function(){
-	return config[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY] || null;
+	var priceGranularity = config[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY] || null;
+
+	if (priceGranularity === CONSTANTS.COMMON.PRICE_GRANULARITY_CUSTOM) {
+		var bucketsValue = refThis.getPriceGranularityBuckets();
+		if(bucketsValue !== null) {
+            return bucketsValue;
+        } else {
+            util.logWarning(CONSTANTS.MESSAGES.M33);
+            return null;
+        }
+	} 
+	else {
+		return priceGranularity;
+	}
+};
+
+exports.getPriceGranularityBuckets = function(){
+	return config[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS] || null;
 };
 
 exports.getGranularityMultiplier = function(){

src_new/constants.js

@@ -46,6 +46,8 @@ exports.COMMON = {
 	"TEST_GROUP_DETAILS": "testConfigDetails",
 	"TEST_PWT": "test_pwt",
 	"PRICE_GRANULARITY" : "priceGranularity",
+	"PRICE_GRANULARITY_CUSTOM" : "custom",
+	"PRICE_GRANULARITY_BUCKETS" : "priceGranularityBuckets",
 	"GRANULARITY_MULTIPLIER" : "granularityMultiplier",
 	"TEST_PARTNER": "test_adapters",
 	"REDUCE_CODE_SIZE": "reduceCodeSize",
@@ -217,6 +219,7 @@ exports.MESSAGES = {
 	"M30": "AB Test Enabled With Config",
 	"M31": "AB Test Enabled With Partner Config",
 	"M32": "Invalid MediaConfig regex pattern : ",
+	"M33": "Price Buckets should be set for custom price granularity",
 	IDENTITY: {
 		M1: "Unable to get User Id from OpenIdentity",
 		M2: "Setting UserIds to EB ",

test/config.spec.js

@@ -2183,11 +2183,13 @@ describe('Config', function() {
     describe('#getPriceGranularity',function(){
         beforeEach(function(done){
             CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY]  = "high";
+            sinon.spy(UTIL, "logWarning");
             done();
         });
 
         afterEach(function(done){
-            delete CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY] ;
+            delete CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY];
+            UTIL.logWarning.restore();
             done();
         })
 
@@ -2207,6 +2209,52 @@ describe('Config', function() {
             expect(CONFIG.getPriceGranularity()).to.equal(null);
             done();
         });
+
+        it('should return PriceGranularity Buckets if price granularity is custom', function(done){
+            CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY] = 'custom';
+            CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS] = 'customBuckets';
+
+            expect(CONFIG.getPriceGranularity()).to.equal('customBuckets');
+            done();
+        });
+
+        it('should return null and log warning if Buckets are missing for custom price granularity', function(done){
+            CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY] = 'custom';
+            delete CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS]
+
+            expect(CONFIG.getPriceGranularity()).to.equal(null);
+            UTIL.logWarning.calledWith(CONSTANTS.MESSAGES.M33).should.be.true;
+            done();
+        });
+    });
+
+    describe('#getPriceGranularityBuckets',function(){
+        beforeEach(function(done){
+            CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS] = "customBuckets";
+            done();
+        });
+
+        afterEach(function(done){
+            delete CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS];
+            done();
+        })
+
+        it('is a function', function(done) {
+            CONFIG.getPriceGranularityBuckets.should.be.a('function');
+            done();
+        });
+
+        it('should return the buckets by reading from config', function(done) {
+            var expectedResult = 'customBuckets';
+            CONFIG.getPriceGranularityBuckets().should.be.deep.equal(expectedResult);
+            done();
+        });
+
+        it('should return null if bucket is not present',function(done){
+            delete CONF[CONSTANTS.CONFIG.COMMON][CONSTANTS.COMMON.PRICE_GRANULARITY_BUCKETS];
+            expect(CONFIG.getPriceGranularityBuckets()).to.equal(null);
+            done();
+        });
     });
 
     describe('#getGranularityMultiplier',function(){