Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding country details in logger call so that publisher can monetise better based on ML recommendations #468

Open
wants to merge 10 commits into
base: nightly
Choose a base branch
from
Open

Adding country details in logger call so that publisher can monetise better based on ML recommendations #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6698842
Adding the change in legacy
pm-priyanka-deshmane Jul 4, 2023
7bdc86a
Removed ES6 syntax
pm-priyanka-deshmane Jul 4, 2023
2fec21c
Merge branch 'UOE-8816' of https://github.com/PubMatic/OpenWrap into …
pm-priyanka-deshmane Jul 4, 2023
db7ac82
Added the code back
pm-priyanka-deshmane Jul 4, 2023
d23f5e5
Merge pull request #474 from PubMatic/nightly_11_july
pm-nitin-shirsat Jul 5, 2023
96699af
Merge branch 'nightly' into UOE-8816
pm-priyanka-deshmane Jul 7, 2023
24dc471
Moved API call in init function
pm-priyanka-deshmane Jul 6, 2023
7b41b30
Fixed test cases
pm-priyanka-deshmane Jul 6, 2023
3ab0d64
Removing storage allowed changes
pm-priyanka-deshmane Jul 7, 2023
54c43c9
Merge branch 'nightly_13_july' into UOE-8816
pm-priyanka-deshmane Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src_new/adapters/prebid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,6 +1357,7 @@ function initPbjsConfig(){
refThis.configureBidderAliasesIfAvailable();
refThis.enablePrebidPubMaticAnalyticIfRequired();
refThis.setPbjsBidderSettingsIfRequired();
util.getGeoInfo();
}
exports.initPbjsConfig = initPbjsConfig;

Expand Down
3 changes: 3 additions & 0 deletions src_new/bidManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,9 @@ exports.executeAnalyticsPixel = function(){ // TDD, i/o : done
outputObj["lip"] = frequencyDepth.lip;
}

if(window.PWT.CC && window.PWT.CC.cc) {
outputObj.ctr = window.PWT.CC.cc;
}
// As discussed we won't be seding gdpr data to logger
// if (CONFIG.getGdpr()) {
// consentString = gdprData && gdprData.c ? encodeURIComponent(gdprData.c) : "";
Expand Down
4 changes: 3 additions & 1 deletion test/controllers/custom.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,8 @@ describe("CONTROLLER: CUSTOM", function() {
sinon.spy(CUSTOM, "setWindowReference");
sinon.spy(CUSTOM, "defineWrapperTargetingKeys");
sinon.spy(CUSTOM, "initSafeFrameListener");
sinon.stub(PREBID, "realignPubmaticAdapters")
sinon.stub(PREBID, "realignPubmaticAdapters");
sinon.stub(UTIL, "getGeoInfo").returns({});
done();
});

Expand All @@ -871,6 +872,7 @@ describe("CONTROLLER: CUSTOM", function() {
CUSTOM.defineWrapperTargetingKeys.restore();
CUSTOM.initSafeFrameListener.restore();
PREBID.realignPubmaticAdapters.restore();
UTIL.getGeoInfo.restore();
done();
});

Expand Down
2 changes: 2 additions & 0 deletions test/controllers/gpt.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2961,6 +2961,7 @@ describe("CONTROLLER: GPT", function() {
sinon.spy(GPT, "addHooksIfPossible");
sinon.spy(GPT, "initSafeFrameListener");
sinon.stub(PREBID, "realignPubmaticAdapters")
sinon.stub(UTIL, "getGeoInfo").returns({});
done();
});

Expand All @@ -2972,6 +2973,7 @@ describe("CONTROLLER: GPT", function() {
GPT.addHooksIfPossible.restore();
GPT.initSafeFrameListener.restore();
PREBID.realignPubmaticAdapters.restore();
UTIL.getGeoInfo.restore();
done();
});

Expand Down