-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UOE-7256: PrebidServerBidAdapatar to support banner profiles #329
Open
kapil-tuptewar
wants to merge
33
commits into
nightly5.x
Choose a base branch
from
UOE-7256
base: nightly5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5984209
Generate adUnit config for PBS
faa7660
Refactored code
1733749
Fixed code review comments
9476dc7
Added query params to endpoint
831991d
Fixed test case for endpoint secnario
4445231
Linting fixes
066a48a
Linting fixes
6506609
Removed query params changes
f14a45b
Linitng fixes
5be1a80
Fix for mi value and removed test param from auction request
11d9581
changed accountId from 1 to publisher id
d5e0362
Passing psltime to logger call in case of PrebidServerBidAdapter
31d8631
Passing psltime to logger call in case of PrebidServerBidAdapter
53285ab
Removed unwanted constant for account id field
2bda6bc
Passed secure config to buildrequest to get secured creative
9936844
Handled error scenario
6f1c8ee
Fix to calculate psl for scenarios like bids and zerobids
5bdf76e
Fix for psl scenarios
fc3bfcb
Fixed regex mapping issue
b7f21d2
Fix for kgpv key
da5aac3
Fixed logger not fired issue
a845be4
Linting fixes
3920869
Added conditional check for psl when there is no server side bidder
68489dc
Passing macros to s2s config
a1a0f79
Fix for logger not showing PubMatic details for zero bid
60937f3
Reverted code for zero bid scenario
6de9055
Fix for zero bid scenario
af58129
Fix for psl when no adslot is enabled and passing correct key to dfp
728c7f4
Removed code for pwtbuyid key
21cd2a7
Fix for zero bid and no bid for PubMatic and alias
1b6ee95
Fix for pubmatic slot not mapped scenario
73053c4
Rebased with nightly5.x
1baf938
Fix for wiid is not passing to pubmatic when adg/pulsepoint/ix partne…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Expected indentation of 3 tabs but found 4.