feat: decouple from express for improved framework support #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibean
force-pushed
the
feat/improve-framework-agnostic-support
branch
from
fc117f7 to
d670d56
Compare
This attempts to remove explicit Express dependencies from csrf-csrf. TypeScript support updated to make use of generics which rely on the underlying Node types instead.
psibean
force-pushed
the
feat/improve-framework-agnostic-support
branch
from
d670d56 to
a327a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept that attemps to remove direct dependencies on
expressfromcsrf-csrf. A TypeScript example usingtinyhttphas been included to demonstrate that it works there, additionally the existing React example has been updated to make use of the adjusted typings.This is just a draft, it's an experiment, it's up here for feedback / testing / reference.
This PR contains breaking changes so should not be merged at this current time.
This is a PoC for issue #67
Still depends on
cookie-parserfor bothexpressandtinyhttp. I considered removingcookie-parserand handling the cookie parsing myself, it seems a bit silly that this isn't something that's centrally available from within Node already.