-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading versions of snarkvm #884
Merged
iamalwaysuncomfortable
merged 30 commits into
ProvableHQ:testnet3
from
Pauan:feat/upgrade-version
Jul 1, 2024
Merged
Changes from 7 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8c581a3
Upgrading versions of snarkvm
Pauan c942fe3
rustfmt
Pauan 02699e7
Updating version of rustc for GitHub Actions
Pauan ae42edc
Updating program unit tests
Pauan d2fb6ed
Fixing testnet URL
Pauan 15f992d
Adding in unit test for TransferPublicVerifier
Pauan 640a96d
Updating parsing unit test
Pauan 9cdf89a
Updating snarkVM commit
Pauan 35ac474
Fixing unit test
Pauan aea94ab
Temporarily disabling some unit tests
Pauan 1465b96
Splitting into multiple unit tests
Pauan b2aa170
Temporarily disabling broken tests
Pauan cbc3421
rustfmt
Pauan 981f16c
Fixing throttling issues with AWS
Pauan 3ae22c2
Fixing some warnings
Pauan e2a38d8
Removing temporary test
Pauan 5044c76
Updating URLs
Pauan 7abefee
Revert "Updating URLs"
Pauan 771d559
Updating URLs
Pauan 05266f1
Updating URLs
Pauan 1ef7ab5
rustfmt
Pauan 32006a2
Updating URLs
Pauan a782365
Combining tests to remove unnecessary fetches
Pauan 57de7e2
Fixing unit test
Pauan 89d79fa
Updating URL
Pauan d4f299a
Consolidating the URL metadata into 1 location
Pauan fac101b
Fixing some bugs
Pauan d4d87de
Updating docs
Pauan ebd5c01
Fixing some unit tests
Pauan 7b18c19
Removing failing unit tests
Pauan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| [toolchain] | ||
| channel = "nightly-2023-05-24" | ||
| channel = "nightly-2024-05-14" | ||
| components = [ "rust-std", "rust-src" ] | ||
| targets = [ "wasm32-unknown-unknown" ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be able to go to
nightly-latest? Opinions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always lock rustc to a specific version, so that way it's reproducible and consistent for everybody. If it's
nightly-latestthen it can cause breakage.Note that the CI matches the version in
rust-toolchain.yaml, so that way the CI will match local dev builds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that locking the version when using nightly is standard best practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed