Repository navigation
feat(backend): graceful shutdown for HTTP server, DB pool, and Redis - #687
Open
woahwhattheheck wants to merge 19 commits into
Open
woahwhattheheck wants to merge 19 commits into
woahwhattheheck wants to merge 19 commits into
Conversation
woahwhattheheck
force-pushed
the
sol56/payd498-graceful-shutdown-20261004
branch
from
October 6, 2026 05:34
d00d041 to
4ba024e
Compare
Author
|
/claim #498 Original-author GrantFox OSS/FWC26 contribution and conditional compensation claim: I, @woahwhattheheck (GitHub account ID 293286387), submit this original contribution for issue #498 and affirmatively claim contributor credit and consideration for any eligible bounty compensation under the campaign terms. Please confirm eligibility, acceptance criteria, award amount (if applicable), and payment instructions. No award or payment is presumed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #498.
What changed
Adds bounded graceful shutdown for the backend process:
Scope
The health controller change adds dependency cleanup only; it does not expose a shutdown-readiness field. No rolling-restart or blue/green deployment behavior is added.
The main configured application PostgreSQL pool and the health-check PostgreSQL/Redis clients are distinct resources; their separate close paths are intentional rather than duplicate-close churn.
Current carrier
ea673fb1c9921fb88168e9d6b8af05598c584a83171c74b454daba241bfb75f36d10a0a3a77a68e5Focused evidence and limits
Current provider source readback confirms
server.close()starts before background cleanup, active background work is drained, cleanup operations use the bounded 10-second helper, dependency cleanup follows HTTP drain, and the handled-signal path callsexit(0)even when cleanup failure is logged. The focused regression explicitly requires zero exit after a rejected background shutdown while still attempting dependency cleanup.Current-head Actions do not establish source-test success:
37563795687: completed / failure / 0 jobs37563794843: completed / failure / 0 jobsValidation is limited to the focused evidence above.
Compensation request
Claimant and payee: @woahwhattheheck. This completed contribution is submitted through the issue's GrantFox route. Please confirm assignment/acceptance, the applicable payable amount, payout method, and timing. I am claiming this delivered contribution and requesting the applicable payment through the existing bounty/reward route; the compensation claim remains active.