-
Notifications
You must be signed in to change notification settings - Fork 23
Update CODEOFCONDUCT.md #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, except that the grid of project administrators doesn't actually include any links to GitHub profiles (just the profile pics). So there's no easy way for people to find individual contact info.
It would be great to use MyST cards for this purpose. We could easily make each picture frame a live link to the person's profile. But this would require moving the whole CoC document onto the published portal site, rather than just living in the repository root.
On the other hand, I think there are good reasons to do exactly that. I'd personally like to see the CoC appear on the portal site nav bar (along with blog, guides, etc) to make it more visible to the public.
@brian-rose Great suggestions! Will look into them |
Add GitHub profile links for each profile picture
remove leftover MyST card directive
Thanks for catching this! Fixed it now (avatars point to GitHub profiles now).
I agree, but given that we cannot get them rendered within the GitHub repo for now, the simplest solution seems like the current one (i.e. the gridded avatars) for the time being. Thoughts?
Done. Please have a look at the preview and let me know how it looks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great and this is a nice solution for making the CoC more visible by including it in the table of contents for the rendered site.
I just found one cosmetic issue with MyST misinterpreting a GitHub link.
Co-authored-by: Brian Rose <[email protected]>
Wow, thanks a lot for catching this and finding the fix for it! Pushed your suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for getting this done @erogluorhan
This PR: