Skip to content

Update CODEOFCONDUCT.md #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 22, 2025
Merged

Update CODEOFCONDUCT.md #553

merged 6 commits into from
Aug 22, 2025

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Aug 19, 2025

This PR:

  • Updates the CoC as follows:
    • Add a list of project administrators with names and avatars, which links to their GitHub profiles, displayed under the "Project Administrator Responsibilities" section. See the screenshot below for reference
    • Add further clarification to communication methods under the "Reporting" section when a reporting is needed
    • Add new "Confidentiality" and "Conflict of Interest" sections into the document
  • Adds CoC into the portal navbar
image

@erogluorhan erogluorhan requested a review from a team as a code owner August 19, 2025 02:19
@erogluorhan erogluorhan requested review from jukent and r-ford and removed request for a team August 19, 2025 02:19
Copy link
Contributor

github-actions bot commented Aug 19, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3e39ccb
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/553

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, except that the grid of project administrators doesn't actually include any links to GitHub profiles (just the profile pics). So there's no easy way for people to find individual contact info.

It would be great to use MyST cards for this purpose. We could easily make each picture frame a live link to the person's profile. But this would require moving the whole CoC document onto the published portal site, rather than just living in the repository root.

On the other hand, I think there are good reasons to do exactly that. I'd personally like to see the CoC appear on the portal site nav bar (along with blog, guides, etc) to make it more visible to the public.

@erogluorhan
Copy link
Member Author

@brian-rose Great suggestions! Will look into them

Add GitHub profile links for each profile picture
remove leftover MyST card directive
@erogluorhan erogluorhan requested a review from a team as a code owner August 20, 2025 20:00
@erogluorhan
Copy link
Member Author

This all looks good, except that the grid of project administrators doesn't actually include any links to GitHub profiles (just the profile pics). So there's no easy way for people to find individual contact info.

Thanks for catching this! Fixed it now (avatars point to GitHub profiles now).

It would be great to use MyST cards for this purpose. We could easily make each picture frame a live link to the person's profile. But this would require moving the whole CoC document onto the published portal site, rather than just living in the repository root.

I agree, but given that we cannot get them rendered within the GitHub repo for now, the simplest solution seems like the current one (i.e. the gridded avatars) for the time being. Thoughts?

On the other hand, I think there are good reasons to do exactly that. I'd personally like to see the CoC appear on the portal site nav bar (along with blog, guides, etc) to make it more visible to the public.

Done. Please have a look at the preview and let me know how it looks.

@erogluorhan erogluorhan requested a review from brian-rose August 20, 2025 20:07
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great and this is a nice solution for making the CoC more visible by including it in the table of contents for the rendered site.

I just found one cosmetic issue with MyST misinterpreting a GitHub link.

Co-authored-by: Brian Rose <[email protected]>
@erogluorhan erogluorhan requested a review from brian-rose August 21, 2025 22:55
@erogluorhan
Copy link
Member Author

I just found one cosmetic issue with MyST misinterpreting a GitHub link.

Wow, thanks a lot for catching this and finding the fix for it! Pushed your suggestion

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for getting this done @erogluorhan

@erogluorhan erogluorhan merged commit 671f3b2 into main Aug 22, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants