Skip to content

Add analytics back! #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Add analytics back! #551

merged 1 commit into from
Aug 6, 2025

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Aug 6, 2025

Adding measurement id

@jukent jukent requested a review from a team as a code owner August 6, 2025 16:27
@jukent jukent requested review from dopplershift, ktyle, rowanc1, kafitzgerald and brian-rose and removed request for a team August 6, 2025 16:27
Copy link
Contributor

github-actions bot commented Aug 6, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: b9a7d1e
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/551

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want instead to put this in the upstream pythia-config so that analytics work across all our sites?

@jukent
Copy link
Contributor Author

jukent commented Aug 6, 2025

Do we want instead to put this in the upstream pythia-config so that analytics work across all our sites?

Oh that's a smart idea. Currently we have a different measurement ID for Cookbooks, the Portal, and Foundations.

We could either:

  • add the Cookbook measurement ID to pythia-config (that will reduce the most redundancy), but then overwrite it in the portal and foundations (so merge this PR anyway)
  • or move to using a constant measurement ID for all "products"

I am not sure why we decided to use different measurement IDs in the first place, but it would disrupt our metrics more to change it now.

@jukent
Copy link
Contributor Author

jukent commented Aug 6, 2025

Keeping this one open, but covering all cookbooks in ProjectPythia/pythia-config#18

@jukent jukent requested a review from brian-rose August 6, 2025 16:43
@jukent jukent merged commit c089095 into ProjectPythia:main Aug 6, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 6, 2025
@jukent jukent deleted the anallytics branch August 6, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants