Add improved support for git and GitHub within JupyterLab #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
dcamron
reviewed
Jul 25, 2025
| set -ex | ||
|
|
||
| # Add support for developing with git and GitHub | ||
| conda install -c conda-forge jupyterlab-git gh-scoped-creds |
There was a problem hiding this comment.
is postBuild run from within the conda environment? Or does this need to specify -n notebook?
There was a problem hiding this comment.
My understanding it is run within the already activated conda environment.
|
Is the new plan to close this? |
|
Could we leave this open for the moment? I am currently working if this is still needed or not (and in discussion internally with 2i2c). I'll swap it to DRAFT for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support git (using the JupyterLab git extension) and GitHub (through gh-scoped-creds), I propose using the postBuild feature of repo2docker to add these additional packages. This means that the environment.yml file remains untouched while adding in these two-packages as 'standard' cookbooks.