Conversation
Signed-off-by: Yun Liu <yunl@nvidia.com>
WalkthroughUpdates CITATION.cff metadata: bumps date-released from 2025-06-13 to 2025-09-22 and version from "1.5.0" to "1.5.1". No other fields changed. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Yun Liu <yunl@nvidia.com>
|
/build |
ericspod
left a comment
There was a problem hiding this comment.
I missed this earlier, thanks for catching it!
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CITATION.cff (1)
135-135: Use bare DOI string, not a URL, per CFF spec.The
doifield should be the DOI (nohttps://doi.org/prefix).- doi: "https://doi.org/10.48550/arXiv.2211.02701" + doi: "10.48550/arXiv.2211.02701"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
CITATION.cff(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: min-dep-os (ubuntu-latest)
- GitHub Check: min-dep-pytorch (2.6.0)
- GitHub Check: min-dep-os (macOS-latest)
- GitHub Check: min-dep-pytorch (2.7.1)
- GitHub Check: min-dep-py3 (3.10)
- GitHub Check: min-dep-pytorch (2.8.0)
- GitHub Check: min-dep-py3 (3.9)
- GitHub Check: min-dep-os (windows-latest)
- GitHub Check: min-dep-pytorch (2.5.1)
- GitHub Check: min-dep-py3 (3.12)
- GitHub Check: min-dep-py3 (3.11)
- GitHub Check: flake8-py3 (mypy)
- GitHub Check: packaging
- GitHub Check: quick-py3 (ubuntu-latest)
- GitHub Check: quick-py3 (windows-latest)
- GitHub Check: build-docs
- GitHub Check: flake8-py3 (codeformat)
- GitHub Check: quick-py3 (macOS-latest)
- GitHub Check: flake8-py3 (pytype)
🔇 Additional comments (1)
CITATION.cff (1)
9-10: Version/date bump to 1.5.1 (2025-09-22) — verify cross-repo consistencyCITATION.cff shows date-released: 2025-09-22 and version: "1.5.1" (lines 9–10).
- Confirm canonical version holders and docs match: pyproject.toml, setup.py / setup.cfg, monai/_version.py, docs/source/conf.py, and the Git tag/release date.
- Run a full repo search for the literal token 1.5.1 (e.g., rg -nP --hidden -S '\b1.5.1\b' .) — ripgrep in the sandbox reported "No files were searched".
- Validate CITATION.cff locally with cffconvert (sandbox import failed); ensure the recorded date equals the actual release/tag date.
Part of Project-MONAI#8569 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yun Liu <yunl@nvidia.com>
Part of Project-MONAI#8569 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yun Liu <yunl@nvidia.com>
Part of #8569
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.