7951 anchors are not centered on grid cells#8475
Open
hachoj wants to merge 4 commits intoProject-MONAI:devfrom
Open
7951 anchors are not centered on grid cells#8475hachoj wants to merge 4 commits intoProject-MONAI:devfrom
hachoj wants to merge 4 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: hachoj <hjchojnowski@gmail.com>
Signed-off-by: hachoj <hjchojnowski@gmail.com>
Signed-off-by: hachoj <hjchojnowski@gmail.com>
Member
|
Hi @hachoj thanks for the contribution, it looks fine to me as far as I can tell. Could you please check that this works with the luna16 tutorial example? If so I think we're good. @Can-Zhao I think you were the original author of this file, any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #7951 by correctly centering anchor boxes within their grid cells.
Description
Changes Made:
monai/apps/detection/utils/anchor_utils.pyto add astride // 2offset.tests/apps/detection/utils/test_anchor_box.pyto validate this new, correct behavior against the torchvision baseline by accounting for the offset.Fixes #7951
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.