Skip to content
This repository was archived by the owner on May 7, 2021. It is now read-only.

UTCとの変換を書いた #167

Merged
merged 3 commits into from
Apr 28, 2019
Merged

Conversation

Fukusan64
Copy link
Contributor

@Fukusan64 Fukusan64 requested a review from gedorinku April 26, 2019 07:59
@@ -155,7 +155,7 @@ export default {
return date;
},
set(newValue) {
this.achievement.happened_at = `${newValue}T00:00:00Z`;
this.achievement.happened_at = `${newValue}T09:00:00Z`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめん、冷静に考えてJST -> UTCの変換なので9時間引かないといけない

@Fukusan64 Fukusan64 changed the title happenedAtのseterの時間の部分を9時にした UTCとの変換を書いた Apr 28, 2019
@Fukusan64
Copy link
Contributor Author

Fukusan64 commented Apr 28, 2019

@gedorinku
JST<->UTCの相互変換にしたけど
よく考えたらJST->UTCしか頼まれてなかった気もするので
まずかったら言ってほしい

Copy link
Member

@gedorinku gedorinku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが正しそう

@gedorinku gedorinku merged commit baca7fc into master Apr 28, 2019
@gedorinku gedorinku deleted the fukusan/fix-achievement-time-zone branch April 28, 2019 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants