FOUR-29436: Unexpected logout when clicking SAVE in Group Permissions#8753
Open
eiresendez wants to merge 2 commits intodevelopfrom
Open
FOUR-29436: Unexpected logout when clicking SAVE in Group Permissions#8753eiresendez wants to merge 2 commits intodevelopfrom
eiresendez wants to merge 2 commits intodevelopfrom
Conversation
Contributor
|
QA server K8S was successfully deployed https://ci-ad89f7662c.engk8s.processmaker.net |
|
Contributor
|
QA server K8S was successfully deployed https://ci-ad89f7662c.engk8s.processmaker.net |
Contributor
Author
|
Hi @rodriquelca, could you please take a look at this PR? The changes touch areas you developed so your input would be very valuable to avoid any side effects. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
This fixes
FOUR-29436.When group permissions are updated, the permission cache invalidation path can clear Redis-backed sessions in production-like environments where both cache and session use Redis. I reproduced the logout locally with:
SESSION_DRIVER=redisCACHE_DRIVER=redisThe runtime path was:
PermissionUpdatedInvalidatePermissionCacheOnUpdate/InvalidatePermissionCacheOnGroupHierarchyChangeinvalidated all permission cachePermissionCacheService::clearAll()called a broad cache clearSolution
user_permissions:{id}user_{id}_permissionsPermissionCacheService::clearAll()safe and scoped to tracked permission keys instead of clearing the whole cache backend.How to Test
./vendor/bin/phpunit --filter 'PermissionCacheServiceTest|PermissionServiceManagerTest|InvalidatePermissionCacheOnUpdateTest|InvalidatePermissionCacheOnGroupHierarchyChangeTest|PermissionCacheInvalidationTest|PermissionsTest'Related Tickets & Packages
ci:deploy
Code Review Checklist