FOUR-24957: Collection Record Control does not work to users different to super admin #8367
+2
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
This PR proposes the removal of a screen access check within the viewScreen policy for tasks.
Currently, the policy performs a validation using:
This check fails to account for screens that are part of FormCollectionRecordControl components. As a result, users with valid task access cannot load certain screens that are dynamically embedded in the process task.
To reproduce:
Solution
This PR is a proposal for simplification. If there are concerns about removing the screen ID validation entirely, alternative approaches include:
While alternatives could work, they would likely add complexity and go beyond the scope of what this PR aims to solve.
How to Test
./vendor/bin/phpunit --filter=ProcessRequestTokenPolicyTest
.Related Tickets & Packages
Code Review Checklist