Skip to content

Move faker to require-dev #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ProcessMaker/Providers/ProcessMakerServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,6 @@ public function register(): void
});
}

// Dusk, if env is appropriate
// TODO Remove Dusk references and remove from composer dependencies
if (!$this->app->environment('production')) {
$this->app->register(DuskServiceProvider::class);
}

$this->app->singleton(Managers\PackageManager::class, function () {
return new Managers\PackageManager();
});
Expand Down
23 changes: 0 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,29 +376,6 @@ Detailed examples can be found at [https://github.com/zircote/swagger-php/tree/m

Full OpenAPI 3.0 specification at [https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md)

**Testing with Laravel Dusk**

When testing in [Laravel Dusk](https://laravel.com/docs/6.x/dusk), make sure to turn off debugging mode in your `.env` so you can use the whole page and screens executing functional tests. Then, change app\_env value to `develop` in the same file:

```text
APP_DEBUG=FALSE
APP_ENV=develop
```

Execute `vagrant ssh` to ssh into the newly created virtual machine.

Execute `php artisan dusk` in `/home/vagrant/processmaker` to execute Laravel dusk test cases.

Execute `php artisan dusk:make newTest` to generate a new Dusk test. The generated test will be placed in the `tests/Browser` directory.

**More Info**

Detailed installation can be found at [https://laravel.com/docs/6.x/dusk#installation](https://laravel.com/docs/6.x/dusk#installation)

To interact with web elements [https://laravel.com/docs/6.x/dusk#interacting-with-elements](https://laravel.com/docs/6.x/dusk#interacting-with-elements)

List of available assertions [https://laravel.com/docs/6.x/dusk#available-assertions](https://laravel.com/docs/6.x/dusk#available-assertions)


# ICONS

Expand Down
10 changes: 0 additions & 10 deletions aliases
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ function artisan() {
php artisan "$@"
}

function dusk() {
pids=$(pidof /usr/bin/Xvfb)

if [ ! -n "$pids" ]; then
Xvfb :0 -screen 0 1280x960x24 &
fi

php artisan dusk "$@"
}

function php56() {
sudo update-alternatives --set php /usr/bin/php5.6
sudo update-alternatives --set php-config /usr/bin/php-config5.6
Expand Down
6 changes: 2 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"composer/semver": "^3.4",
"darkaonline/l5-swagger": "^8.6",
"doctrine/dbal": "^4.2",
"fakerphp/faker": "^1.24",
"google/apiclient": "^2.18",
"guzzlehttp/guzzle": "^7.9",
"igaster/laravel-theme": "^2.0",
Expand Down Expand Up @@ -68,8 +67,8 @@
"whichbrowser/parser": "^2.1"
},
"require-dev": {
"fakerphp/faker": "^1.24",
"filp/whoops": "^2.16",
"laravel/dusk": "^8.2",
"laravel/homestead": "^15.0",
"mockery/mockery": "^1.6",
"phpunit/phpunit": "^12",
Expand Down Expand Up @@ -97,7 +96,6 @@
"extra": {
"laravel": {
"dont-discover": [
"laravel/dusk",
"laravel/passport"
]
},
Expand Down Expand Up @@ -227,4 +225,4 @@
"tbachert/spi": true
}
}
}
}
268 changes: 64 additions & 204 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading