Skip to content

Conversation

@nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Jan 7, 2025

Issue & Reproduction Steps

There were 2 problems here

  • When a user was added to a group using the Admin interface, timestamps were not saved in the group_members table. These group associations were getting cleared every time LDAP ran because it looks for a null created_at to know if the association was created with LDAP
  • The auth package was attempting to sync (and clearing the associations) even if the connection to the LDAP server was invalid

Solution

  • Core: Fix timestamps when adding a user to a group in the User settings
  • package-auth: Test the connection before attempting to sync

How to Test

See reproduction steps in the jira ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro nolanpro requested a review from danloa January 7, 2025 01:37
@nolanpro nolanpro changed the base branch from release-2024-fall to release-2025-spring April 2, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants