Move all print statements to execute() #435
Conversation
| @@ -185,20 +185,40 @@ specfem::IO::read_mesh(const std::string filename, | |||
|
|
|||
| stream.close(); | |||
|
|
|||
| // Print material properties | |||
| const auto &l_elastic_isotropic = | |||
There was a problem hiding this comment.
Instead of a separate print mesh function, the osstream operator could be overloaded like so:
class A {
int val;
public:
A(int v) : val(v) {}
friend ostream& operator<<(ostream& os, const A& obj) {
os << obj.val;
return os;
}
};then you can just
std::cout << mesh << std::endl;There was a problem hiding this comment.
If we define std::cout << mesh, it should call mesh.print(), which is already defined and prints different stuff.
| void print(std::ostream &out) const { | ||
| out << " Quadrature in X-dimension \n"; | ||
| gll.print(out); | ||
|
|
||
| out << " Quadrature in Z-dimension \n"; | ||
| gll.print(out); | ||
| } |
There was a problem hiding this comment.
std::cout << gll has already been defined, but at this stage not declared. I could use some help on the import order.
| @@ -41,8 +41,15 @@ void execute( | |||
| // -------------------------------------------------------------- | |||
| // Read mesh and materials | |||
| // -------------------------------------------------------------- | |||
| const auto quadrature = setup.instantiate_quadrature(); | |||
| const auto quadratures = setup.instantiate_quadrature(); | |||
| if (mpi->main_proc()) { | |||
There was a problem hiding this comment.
I think the options are two, either you check here whether it's the main_proc() and then use the ostream << overload, or you parse mpi check locally if you are on main_proc and return if you aren't.
What do you think? Am i forgetting something?
Option 3:
the struct should all have the osstream overload. mpi->cout should really check whether you are on main proc.
Issue Number
Closes #434