Add an interception app configuration hook before startup - #2560
Closed
faresobeid wants to merge 1 commit into
Closed
Add an interception app configuration hook before startup#2560faresobeid wants to merge 1 commit into
faresobeid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InterceptionServer.start()freezes its aiohttp router before returning, so a subclass cannot register additional routes aftersuper().start(). Add a protected_configure_app(app)hook after the built-in routes are registered and beforeAppRunner.setup()freezes the application.The default hook is a no-op. Server startup, authentication, tunnel exposure and cleanup remain owned by the existing lifecycle.
Validation: a local HTTP regression fails with 404 before the change and passes afterward. It verifies registration before freeze, exactly one hook call, unchanged authorization on
/state, and listener shutdown. The offline suite passed 83 tests; 76 live tests were excluded. Ruff and all-file pre-commit checks passed.Note
Add interception app configuration hook before startup
Adds an end-to-end test in test_e2e.py that defines an
InterceptionServersubclass overriding application configuration before startup. The test verifies the subclass route is reachable after startup, the configured application becomes router-frozen, protected state routes still reject requests, and the server stops accepting connections after shutdown.Macroscope summarized cd47bf9.